Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented Open Source Contributor Rating for contributor table #3643

Merged
merged 14 commits into from
Jun 27, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Jun 26, 2024

Description

Implements the Open Source Contributor Rating (OSCR) in the contributor table. Note that it is optional to display as it is feature flagged and on some views, the information currently isn't available, e.g. contributors table in the explore pages.

Related Tickets & Documents

Closes #3645

Mobile & Desktop Screenshots/Recordings

Grid View

CleanShot 2024-06-27 at 16 57 13

Card View

image

Small Screen

CleanShot 2024-06-27 at 16 57 49

Logged Out or Without the OSCR Rating Feature Flag Enabled

CleanShot 2024-06-27 at 16 54 51

With the OSCR Rating Feature Flag Enabled

CleanShot 2024-06-27 at 16 46 42

CleanShot 2024-06-27 at 16 45 22

Steps to QA

Logged Out

  1. Go to a public workspace contributor insight page
  2. Notice there is no OSCR Rating in the grid rows or mobile view.

Logged In without OSCR Rating Feature Flag Enabled

  1. Go to any workspace contributor insight page you have access to (public or private)
  2. Notice there is no OSCR Rating in the grid rows or mobile view. The exception is if you're in the contributor table, you'll be able to see your own OSCR.

Logged In with OSCR Rating Feature Flag Enabled

  1. Go to any workspace contributor insight page you have access to (public or private)
  2. Notice the OSCR Rating in the grid rows or mobile view.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 7220ae5
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/667dd1833c5be2000863851f
😎 Deploy Preview https://deploy-preview-3643--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 7220ae5
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/667dd183908d450008af1a83
😎 Deploy Preview https://deploy-preview-3643--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline changed the title feat: implemented OSCR rating for contributor table and contributor cards" feat: implemented OSCR rating for contributor table Jun 26, 2024
@nickytonline nickytonline force-pushed the nickytonline/oscr-rating branch from 4b2a879 to e8b0e3c Compare June 26, 2024 22:03
@nickytonline nickytonline marked this pull request as ready for review June 26, 2024 22:04
@nickytonline nickytonline requested review from BekahHW, a team and isabensusan June 26, 2024 22:04
components/Contributors/OscrRating.tsx Outdated Show resolved Hide resolved
lib/hooks/api/useContributorList.ts Outdated Show resolved Hide resolved
@nickytonline nickytonline force-pushed the nickytonline/oscr-rating branch from 1d6256f to 97e6850 Compare June 27, 2024 02:40
@nickytonline nickytonline force-pushed the nickytonline/oscr-rating branch from cd743ab to fe16ef8 Compare June 27, 2024 02:53
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼 💪🏼

@nickytonline nickytonline changed the title feat: implemented OSCR rating for contributor table feat: implemented Open Source Contributor Rating for contributor table Jun 27, 2024
@bdougie
Copy link
Member

bdougie commented Jun 27, 2024

Drop the %. It's cleaner.

image

@nickytonline
Copy link
Member Author

nickytonline commented Jun 27, 2024

Drop the %. It's cleaner.

@bdougie, removed it in 1f1cbc0

@nickytonline
Copy link
Member Author

I'll be chatting with @isabensusan @bdougie, so will look into the mobile experience for this as discussed in the engineering sync.

@nickytonline
Copy link
Member Author

Made the changes @isabensusan.

CleanShot 2024-06-27 at 16 46 42

CleanShot 2024-06-27 at 16 45 22

@nickytonline nickytonline merged commit 68e8494 into beta Jun 27, 2024
19 checks passed
@nickytonline nickytonline deleted the nickytonline/oscr-rating branch June 27, 2024 21:04
open-sauced bot pushed a commit that referenced this pull request Jun 27, 2024
## [2.40.0-beta.2](v2.40.0-beta.1...v2.40.0-beta.2) (2024-06-27)

### 🍕 Features

* implemented Open Source Contributor Rating for contributor table ([#3643](#3643)) ([68e8494](68e8494))
open-sauced bot pushed a commit that referenced this pull request Jun 27, 2024
## [2.40.0](v2.39.0...v2.40.0) (2024-06-27)

### 🍕 Features

* created the OSCR rating feature flag ([#3642](#3642)) ([2db70a2](2db70a2))
* implemented Open Source Contributor Rating for contributor table ([#3643](#3643)) ([68e8494](68e8494))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: First Iteration of OSCR intergation with Contributor Insights
4 participants