Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelhttp: Treat http.NoBody the same as a nil body #2983

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

dashpole
Copy link
Contributor

Fixes #2982

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #2983 (9754ab3) into main (9a9abd4) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2983     +/-   ##
=======================================
- Coverage   69.7%   69.6%   -0.1%     
=======================================
  Files        147     147             
  Lines       6806    6806             
=======================================
- Hits        4746    4743      -3     
- Misses      1944    1946      +2     
- Partials     116     117      +1     
Impacted Files Coverage Δ
instrumentation/net/http/otelhttp/handler.go 81.9% <100.0%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.0% <0.0%> (-1.0%) ⬇️

@dashpole dashpole added the bug Something isn't working label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelhttp's body wrapper doesn't respect NoBody
4 participants