Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: Implement With method #5653

Merged
merged 15 commits into from
May 31, 2024
Merged

Conversation

khushijain21
Copy link
Contributor

Part of #5191

Pre-work #5279

This PR implements With method

@khushijain21 khushijain21 requested review from pellared and a team as code owners May 23, 2024 11:32
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.6%. Comparing base (1c1ec18) to head (82673c1).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5653   +/-   ##
=====================================
  Coverage   63.5%   63.6%           
=====================================
  Files        194     194           
  Lines      12064   12071    +7     
=====================================
+ Hits        7670    7681   +11     
+ Misses      4178    4175    -3     
+ Partials     216     215    -1     
Files Coverage Δ
bridges/otelzap/core.go 96.5% <100.0%> (+2.8%) ⬆️

... and 1 file with indirect coverage changes

@pellared pellared changed the title otelzap: Implement with method otelzap: Implement With method May 23, 2024
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 23, 2024
bridges/otelzap/core.go Outdated Show resolved Hide resolved
bridges/otelzap/core.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
khushijain21 and others added 3 commits May 31, 2024 12:25
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared pellared merged commit 1c87c13 into open-telemetry:main May 31, 2024
24 checks passed
@khushijain21 khushijain21 deleted the zapwith branch May 31, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants