PoC: Update Jaeger exporter to rely on the SDK for batching and NoOp performance #1803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cloud.google.com/go
by removing the use of the providedBundler
.ExportSpans
and rely on theBatchSpanProcessor
for batching.ExportSpans
so there is no use for a flush function.InstallNewPipeline
andNewExportPiepeline
) to not return the now unneeded flush function.WithBufferMaxCount
option. The Jaeger exporter no longer bundles.WithBatchMaxCount
option. The Jaeger exporter no longer bundles.WithDisabled
option. Unregistered the wrapping span processor from the TracerProvider or do not set a global TracerProvider for instrumentation to use.WithSDKOptions
option and instead pass these options directly to the convenience creation functions.Option
type. There is not configuration needed to be set for the Jaeger exporter other than endpoint configuration (which is handled by the respective uploader configuration).Process
type. This is leftover from Remove process config for Jaeger exporter #1776.ExportSpans
Benchmarks
Before
After
Related Issues
Resolve #1799