Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish wheels for 3.8, 3.9, and arm64; remove deprecated 3.5 #79

Merged
merged 9 commits into from
May 14, 2021

Conversation

adversariel
Copy link
Contributor

No description provided.

@adversariel adversariel requested a review from pzhokhov May 13, 2021 06:25
multibuild.sh Outdated

git clone https://github.com/matthew-brett/multibuild && cd multibuild && git checkout 254ad28 && cd ..
git clone https://github.com/matthew-brett/multibuild && cd multibuild && cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe still pin it to a new commit?

Copy link
Contributor

@pzhokhov pzhokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than unpinned commit, LGTM!

@adversariel adversariel merged commit f0dff84 into master May 14, 2021
@adversariel adversariel deleted the adversariel/fix-build branch May 14, 2021 00:09
@araffin
Copy link

araffin commented May 25, 2021

it seems that this PR (or at least the accompanying release) is responsible for breaking atari-py (no ROM found when trying to create gym env).

@Denbergvanthijs
Copy link

Denbergvanthijs commented May 27, 2021

The following works for us as a temporary fix:

wget -O Roms.rar http://www.atarimania.com/roms/Roms.rar
unrar e Roms.rar
python -m atari_py.import_roms ./

@selenecodes
Copy link

For now using gym==0.18.0 and atari-py==0.2.5 seems to work.

rossbar added a commit to rossbar/numpy-tutorials that referenced this pull request Jun 17, 2021
PaulMcMillan pushed a commit that referenced this pull request Apr 25, 2023
* Switch to multibuild main branch

* Add Python 3.8 and 3.9 builds to CI

* Add more build architectures

* Pass arch flag into multibuild

* Use docker-compatible arch flags

* Switch to use manylinux2014 container for builds

* Specify test image for arm64 builds

* Remove legacy python 3.5 build

* Pinned multibuild to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants