-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish wheels for 3.8, 3.9, and arm64; remove deprecated 3.5 #79
Conversation
multibuild.sh
Outdated
|
||
git clone https://github.com/matthew-brett/multibuild && cd multibuild && git checkout 254ad28 && cd .. | ||
git clone https://github.com/matthew-brett/multibuild && cd multibuild && cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe still pin it to a new commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than unpinned commit, LGTM!
it seems that this PR (or at least the accompanying release) is responsible for breaking atari-py (no ROM found when trying to create gym env). |
The following works for us as a temporary fix: wget -O Roms.rar http://www.atarimania.com/roms/Roms.rar
unrar e Roms.rar
python -m atari_py.import_roms ./ |
For now using |
* Switch to multibuild main branch * Add Python 3.8 and 3.9 builds to CI * Add more build architectures * Pass arch flag into multibuild * Use docker-compatible arch flags * Switch to use manylinux2014 container for builds * Specify test image for arm64 builds * Remove legacy python 3.5 build * Pinned multibuild to latest version
No description provided.