feat: update default #4076
feat: update default #4076
Conversation
...s/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__binary_size_ideal_response.snap
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| const OPENAI_DEFAULT_MODEL: &str = "gpt-5-codex"; | ||
| const OPENAI_DEFAULT_REVIEW_MODEL: &str = "gpt-5-codex"; | ||
| pub const GPT_5_CODEX_MEDIUM_MODEL: &str = "gpt-5-codex"; |
There was a problem hiding this comment.
[P1] Update model_verbosity handling for gpt-5-codex default
Changing the default OpenAI model to gpt-5-codex means the new default Config carries the gpt-5-codex family, but the request builder only emits the text.verbosity field when the family is exactly "gpt-5" (see client.rs’s guard). With the new default, any configured model_verbosity is now ignored and a warning is logged, so users can no longer control verbosity for the default model even though the feature worked before. Unless codex intentionally lacks this field, the check should treat gpt-5-codex as supporting text.verbosity as well.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
We should rename these consts instead.
Changes: