Add turn started/completed events and correct exit code on error #4309
+192
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # codex-rs/exec/src/exec_events.rs # codex-rs/exec/src/experimental_event_processor_with_json_output.rs # codex-rs/exec/tests/event_processor_with_json_output.rs
… list test Previously, the test only asserted ItemCompleted event. Update to also expect a SessionCompleted event with default usage, matching actual event sequence.
pakrym-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
…ted event - Replace SessionCompletedEvent and session.completed with TurnCompletedEvent and turn.completed in exec_events and processor - Introduce TurnStartedEvent and turn.started variant in ConversationEvent - Propagate changes to experimental_event_processor_with_json_output and adjust handling for TaskStarted/TaskComplete - Update usage summaries and associated tests for turn semantics
pakrym-oai
changed the title
bolinfest
approved these changes
Sep 26, 2025
Comment on lines
+352
to
+354
| if error_seen { | ||
| std::process::exit(1); | ||
| } |
There was a problem hiding this comment.
Do you want to return a special type of Error and handle std::process::exit() higher up?
There was a problem hiding this comment.
yes, but outside of this PR, there are many std::process::exits in that file that I'd like to clean up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new event for session completed that includes usage. Also ensures we return 1 on failures.