fix: clean up some minor issues with .github/workflows/ci.yml #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Sep 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
pull_request: { branches: [main] }topull_request: {}(which is what we do inrust-ci.yml, for example) because if you require the base branch to bemainand you use stacked PRs, the CI job only gets run for the PR on the bottom of the stackI started looking at the second issue because I thought the step wasn't working (though it is). The issue is that the PR UI here on GitHub will link you to the job:
https://github.com/openai/codex/actions/runs/18078793569/job/51439094961?pr=4408
and if you dig through the logs, you can get a download URL for the artifact, but the easier thing is to cut off the end of the URL and view this instead:
https://github.com/openai/codex/actions/runs/18078793569/
where the download link is prominent: