Skip to content

Conversation

aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Sep 29, 2025

Fixing the "? for shortcuts"

  • Only show the hint when composer is empty
  • Don't reset footer on new task updates
  • Reorder the elements
  • Align the "?" and "/" with overlay on and off

Based on #4364

@aibrahim-oai aibrahim-oai changed the base branch from main to revert-4362-revert-prs-4316-4330 September 29, 2025 20:08
Copy link
Contributor

💡 Codex Review

pub(crate) fn toggle_shortcut_mode(current: FooterMode, _ctrl_c_hint: bool) -> FooterMode {
match current {
FooterMode::ShortcutOverlay | FooterMode::CtrlCReminder => FooterMode::ShortcutPrompt,
_ => FooterMode::ShortcutOverlay,
}

[P1] Preserve Ctrl+C quit reminder when toggling shortcut overlay

The new toggle_shortcut_mode ignores the ctrl_c_hint flag, so pressing ? now flips the footer into ShortcutOverlay even when the Ctrl+C confirmation hint is active. In that state the UI replaces the required "ctrl + c again to quit/interrupt" message with the generic shortcuts overlay, which can leave users without the prompt needed to exit a running task. Previously the guard prevented toggling while ctrl_c_quit_hint was true. Consider keeping the hint visible (or at least merging its text into the overlay) whenever the quit reminder is active.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@aibrahim-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Base automatically changed from revert-4362-revert-prs-4316-4330 to main September 29, 2025 23:35
@aibrahim-oai
Copy link
Collaborator Author

@codex code a fix for the merge conflict with latest main

Copy link
Contributor

Summary

Testing

  • cargo test -p codex-tui

View task →

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) September 30, 2025 00:01
@aibrahim-oai aibrahim-oai merged commit c64da4f into main Sep 30, 2025
19 checks passed
@aibrahim-oai aibrahim-oai deleted the fixes branch September 30, 2025 00:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants