Add Updated at time in resume picker #4468
Conversation
|
@codex review this |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
|
|
||
| /// Hard cap to bound worst‑case work per request. | ||
| const MAX_SCAN_FILES: usize = 100; | ||
| const MAX_SCAN_FILES: usize = 10000; |
There was a problem hiding this comment.
this seems high; what's the reasoning behind bumping it?
There was a problem hiding this comment.
I wasn’t able to go beyond 4 days in history. We do lazy search anyways so let’s not have a smaller upper cap
| let created_span = if max_created_width == 0 { | ||
| None | ||
| } else { | ||
| Some(Span::from(format!("{created_label:<max_created_width$}")).dim()) |
There was a problem hiding this comment.
Span::from is redundant here, as format!().dim() already returns a span.
| preview_width = preview_width.saturating_sub(marker_width); | ||
| if max_created_width > 0 { | ||
| preview_width = preview_width.saturating_sub(max_created_width + 2); | ||
| } | ||
| if max_updated_width > 0 { | ||
| preview_width = preview_width.saturating_sub(max_updated_width + 2); | ||
| } | ||
| let add_leading_gap = max_created_width == 0 && max_updated_width == 0; |
There was a problem hiding this comment.
I assume there's a good reason we aren't using ratatui::Widget::Table?
Uh oh!
There was an error while loading. Please reload this page.