Skip to content

Conversation

dedrisian-oai
Copy link
Collaborator

@dedrisian-oai dedrisian-oai commented Sep 29, 2025

Here's the logic:

  1. If text is empty and selector is open:
  • Enter on a prompt without args should autosubmit the prompt
  • Enter on a prompt with numeric args should add /prompts:name to the text input
  • Enter on a prompt with named args should add /prompts:name ARG1="" ARG2="" to the text input
  1. If text is not empty but no args are passed:
  • For prompts with numeric args -> we allow it to submit (params are optional)
  • For prompts with named args -> we throw an error (all params should have values)
Screenshot 2025-09-23 at 2 23 21 PM

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@dedrisian-oai
Copy link
Collaborator Author

@codex review pls

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@dedrisian-oai dedrisian-oai merged commit 3592ecb into main Sep 30, 2025
19 checks passed
@dedrisian-oai dedrisian-oai deleted the daniel/custom-prompt-named-args branch September 30, 2025 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants