Skip to content

Move PR-style review to top #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
+14 −14
Merged

Move PR-style review to top #4486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9670cd3
Move review against base branch to top
dedrisian-oai Sep 30, 2025
f443f11
pr style desc
dedrisian-oai Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions codex-rs/tui/src/chatwidget.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,6 +1778,20 @@ impl ChatWidget {
pub(crate) fn open_review_popup(&mut self) {
let mut items: Vec<SelectionItem> = Vec::new();

items.push(SelectionItem {
name: "Review against a base branch".to_string(),
description: Some("(PR Style)".into()),
is_current: false,
actions: vec![Box::new({
let cwd = self.config.cwd.clone();
move |tx| {
tx.send(AppEvent::OpenReviewBranchPicker(cwd.clone()));
}
})],
dismiss_on_select: false,
search_value: None,
});

items.push(SelectionItem {
name: "Review uncommitted changes".to_string(),
description: None,
Expand Down Expand Up @@ -1811,20 +1825,6 @@ impl ChatWidget {
search_value: None,
});

items.push(SelectionItem {
name: "Review against a base branch".to_string(),
description: None,
is_current: false,
actions: vec![Box::new({
let cwd = self.config.cwd.clone();
move |tx| {
tx.send(AppEvent::OpenReviewBranchPicker(cwd.clone()));
}
})],
dismiss_on_select: false,
search_value: None,
});

items.push(SelectionItem {
name: "Custom review instructions".to_string(),
description: None,
Expand Down
Loading