fix: remove mcp-types from app server protocol #4537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
approved these changes
Oct 1, 2025
|
ConversationId really needed to be in the main protocol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue the separation between
codex app-serverandcodex mcp-server.In particular, we introduce a new crate,
codex-app-server-protocol, and migratecodex-rs/protocol/src/mcp_protocol.rsinto it, renaming itcodex-rs/app-server-protocol/src/protocol.rs.Because
ConversationIdwas defined inmcp_protocol.rs, we move it into its own file,codex-rs/protocol/src/conversation_id.rs, and because it is referenced in a ton of places, we have to touch a lot of files as part of this PR.We also decide to get away from proper JSON-RPC 2.0 semantics, so we also introduce
codex-rs/app-server-protocol/src/jsonrpc_lite.rs, which is basically the sameJSONRPCMessagetype defined inmcp-typesexcept with all of the"jsonrpc": "2.0"removed.Getting rid of
"jsonrpc": "2.0"makes our serialization logic considerably simpler, as we can lean heavier on serde to serialize directly into the wire format that we use now.