feat: add file name to fuzzy search response #4619
Merged
+82
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
shijie-oai
force-pushed
the
shijie/update-fuzzy-search-result
branch
from
c63d7f3 to
0dd1caa
Compare
shijie-oai
commented
Oct 2, 2025
| Ok(Ok((root, res))) => { | ||
| for m in res.matches { | ||
| let path = m.path; | ||
| //TODO(shijie): Move file name generation to file_search lib. |
There was a problem hiding this comment.
Will address moving the file name logic and prettier CLI file search in separate PRs.
shijie-oai
force-pushed
the
shijie/update-fuzzy-search-result
branch
from
0dd1caa to
ae9d122
Compare
bolinfest
reviewed
Oct 2, 2025
Yes mainly convenience - also if we want to apply the same UI improvement to the CLI tool it gives us the freedom to do so too. |
shijie-oai
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
shijie-oai
commented
Oct 2, 2025
|
/recheck |
shijie-oai
force-pushed
the
shijie/update-fuzzy-search-result
branch
from
ee80f0c to
5134801
Compare
gpeal
approved these changes
Oct 2, 2025
shijie-oai
force-pushed
the
shijie/update-fuzzy-search-result
branch
from
5134801 to
6acf1da
Compare
shijie-oai
force-pushed
the
shijie/update-fuzzy-search-result
branch
from
6acf1da to
867c091
Compare
shijie-oai
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Tested locally and with the extension.
Screenshot