fix: exec commands that blows up context window. #4706
Merged
+237
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
changed the title
aibrahim-oai
changed the title
pakrym-oai
previously approved these changes
Oct 4, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jif-oai
approved these changes
Oct 4, 2025
| truncate_formatted_exec_output(content) | ||
| } | ||
|
|
||
| fn truncate_formatted_exec_output(content: &str) -> String { |
There was a problem hiding this comment.
OK for now but we will have to merge later all the truncation code we have everywhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We truncate the output of exec commands to not blow the context window. However, some cases we weren't doing that. This caused reports of people with 76% context window left facing
input exceeded context windowwhich is weird.