Fix: enforce strict instructions function signature in get_system_prompt #1426
+130
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
requested changes
Aug 12, 2025
|
It seems the tests are still failing |
seratch
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Agentclass allowed dynamic instructions functions with any two parameters,including meaningless dummy names (e.g.,
def f(wrapper, a)), which caused confusion andallowed improper usage.
This commit adds strict signature checking in
get_system_promptto ensure the instructionscallable accepts exactly two parameters (context and agent), enforcing correct usage.
If the function signature does not have exactly two parameters, a clear TypeError is raised.
This prevents dummy or incorrect parameter usage, improving API correctness and developer
experience.