Migrate openai from 1.x to 2.2.0 #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to resolve mypy errors |
seratch
force-pushed
the
openai-package-v2
branch
from
4abe5fa to
e4fe1e0
Compare
seratch
commented
Oct 10, 2025
| .python-version | ||
| .env* | ||
| .venv | ||
| .venv* |
There was a problem hiding this comment.
just to do python 3.9 more easily
There was a problem hiding this comment.
we can actually remove 3.9 support soon, it is EOL this month
| ) from _e | ||
|
|
||
| from openai import NOT_GIVEN, AsyncStream, NotGiven | ||
| from openai import AsyncStream, NotGiven, omit |
There was a problem hiding this comment.
not_given still exists for backward-compatibility but migrating to omit lets this code base fully align with any patterns
|
@rm-openai now this PR is ready. all the things are internal changes; no public interface level breaking changes. that said, given the code changes and incompatibility with openai 1.x series, releasing a new minor version should be necessary |
rm-openai
approved these changes
Oct 11, 2025
| .python-version | ||
| .env* | ||
| .venv | ||
| .venv* |
There was a problem hiding this comment.
we can actually remove 3.9 support soon, it is EOL this month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1867 This is a blocker for developers trying ChatKit Python server SDK, so we should release a new version including this bump as early as possible.
I've confirmed migrating to 2.x major version does not bring any incompatibility issues with examples in this repo.