Skip to content

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented May 23, 2025

Summary

  • avoid AttributeError when Gemini API returns None for chat message
  • return empty output if message is filtered
  • add regression test

Testing

  • make format
  • make lint
  • make mypy
  • make tests

Towards #744

@rm-openai rm-openai merged commit 6e078bf into main May 23, 2025
5 checks passed
@rm-openai rm-openai deleted the codex/fix-attributeerror-with-gemini-api-and-tools branch May 23, 2025 17:00
@micsom
Copy link

micsom commented May 25, 2025

THIS IS AMAZING!!!!!! OH WOUW!!!!!

KatHaruto pushed a commit to KatHaruto/openai-agents-python that referenced this pull request Jun 10, 2025
- avoid AttributeError when Gemini API returns `None` for chat message
- return empty output if message is filtered
- add regression test

- `make format`
- `make lint`
- `make mypy`
- `make tests`

Towards openai#744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants