Skip to content

Conversation

rohanoai
Copy link

Can now call openai tools fine_tunes.prepare_data -f dbpedia_samples.jsonl without bugs.

@rohanoai rohanoai requested a review from ted-at-openai July 28, 2022 00:36
@shyamal-anadkat
Copy link
Collaborator

@rohanoai do you still want to proceed with this change?

@ted-at-openai
Copy link
Collaborator

ted-at-openai commented Oct 27, 2022

@rohanoai do you still want to proceed with this change?

My hesitation in merging this change is that it turns descriptive column names (text, category) into abstract fine-tuning-specific column names (prompt, completion). Given that our current example doesn't use fine-tuning, it feels like it might confuse folks if they import a data table that names categories as completions. They may wonder, "huh, is this machine generated data? Why is it called completions?" without realizing that it's written as a fine-tuning dataset.

My preference would be to keep the adjustment to the data class representation (so that it's less likely to cause problems with fine-tuning should someone wish to) but not to change the column names to prompt & completion.

Thoughts?

@rohanoai rohanoai closed this Nov 24, 2022
@simonpfish simonpfish deleted the rohanoai/update-examples branch September 20, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants