Skip to content

Conversation

steven10a
Copy link
Collaborator

  • Made Presidio a required dep
  • Updated docs and readme to reflect this
  • Changed hello_world.py to use PII as a preflight instead of input

@Copilot Copilot AI review requested due to automatic review settings October 4, 2025 02:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes Presidio a required dependency for the Guardrails library and updates the codebase to remove optional import handling. The changes streamline the dependency management by moving Presidio from an optional extra to a core requirement.

Key changes:

  • Made presidio-analyzer a required dependency in pyproject.toml instead of an optional extra
  • Removed TYPE_CHECKING imports and exception handling for missing Presidio packages
  • Updated example configuration to use PII detection as a preflight check instead of input check

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/guardrails/checks/text/secret_keys.py Removed optional Presidio import handling and moved imports to top level
src/guardrails/checks/text/pii.py Removed TYPE_CHECKING imports and error handling for missing Presidio
pyproject.toml Moved presidio-analyzer from optional "presidio" extra to required dependencies
examples/basic/hello_world.py Changed PII detection from input to pre_flight guardrail
docs/quickstart.md Removed optional Presidio installation instructions
README.md Updated installation instructions to remove optional Presidio dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@steven10a steven10a requested a review from gabor-openai October 4, 2025 02:25
Copy link
Collaborator

@gabor-openai gabor-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@gabor-openai gabor-openai merged commit b59c76d into main Oct 4, 2025
3 checks passed
@steven10a steven10a deleted the dev/steven/presidio_bug branch October 6, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants