Skip to content

chore(azure): batch API is not a deployments endpoint #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

chore(azure): batch API is not a deployments endpoint #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,6 @@ const _deployments_endpoints = new Set([
'/audio/translations',
'/audio/speech',
'/images/generations',
'/batches',
]);

const API_KEY_SENTINEL = '<Missing Key>';
Expand Down
6 changes: 3 additions & 3 deletions tests/lib/azure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,15 +290,15 @@ describe('azure request building', () => {
fetch: testFetch,
});

test('handles Batch', async () => {
test('handles batch', async () => {
expect(
await client.batches.create({
completion_window: '24h',
endpoint: '/v1/chat/completions',
input_file_id: 'file-id',
}),
).toStrictEqual({
url: `https://example.com/openai/deployments/${deployment}/batches?api-version=${apiVersion}`,
url: `https://example.com/openai/batches?api-version=${apiVersion}`,
});
});

Expand Down Expand Up @@ -423,7 +423,7 @@ describe('azure request building', () => {
fetch: testFetch,
});

test('Batch is not handled', async () => {
test('handles batch', async () => {
expect(
await client.batches.create({
completion_window: '24h',
Expand Down