Speed up imports #386
Merged
Speed up imports #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
This looks great!
re: #380 (comment)
I think fine to split up the helpers. If you end up needing to do something more general, could use a nice module __getattr__:
# lazy.py
def __getattr__(name):
if name == "np":
import numpy # TODO: raise the nice MissingDependencyError
globals()["np"] = numpy
return numpy
...
and then use lazy.np everywhere you'd use np.
ddeville
approved these changes
Apr 8, 2023
|
@hallacy Was curious about what tool you used to get the visualization above. |
|
Looks like tuna? I've seen some accuracy issues using tuna, I recommend one of these two: #380 (comment) |
Thanks @hauntsaninja. From the README of tuna it sounds like it's also compatible with |
davedittrich
pushed a commit
to davedittrich/openai-python
that referenced
this pull request
Nov 14, 2023
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
stainless-app bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
…-changes--next--components--openai release: 4.12.4
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
Slot had inconsistent name. `"first_byte_at"` -> `"first_content_at"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes pandas (no resource uses it) and fixes aiohttp importing as suggested in #380.
I think this gets us from ~5 seconds to 2.5 seconds:
