Skip to content

chore(internal): rubocop rules #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

chore(internal): rubocop rules #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ Layout/LineLength:
AllowedPatterns:
- "^\\s*#.*$"
- ^require(_relative)?
- "OpenAI::Internal::Type::BaseModel$"
- "^\\s*[A-Z0-9_]+ = :"
- "OpenAI::(Models|Resources|Test)::"
Max: 110

Expand Down Expand Up @@ -109,8 +111,7 @@ Metrics/MethodLength:
Enabled: false

Metrics/ModuleLength:
Exclude:
- "**/*.rbi"
Enabled: false

Metrics/ParameterLists:
Enabled: false
Expand Down
2 changes: 0 additions & 2 deletions lib/openai/internal/type/converter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
module OpenAI
module Internal
module Type
# rubocop:disable Metrics/ModuleLength
# @api private
module Converter
# rubocop:disable Lint/UnusedMethodArgument
Expand Down Expand Up @@ -218,7 +217,6 @@ def dump(target, value)
end
end
end
# rubocop:enable Metrics/ModuleLength
end
end
end
4 changes: 0 additions & 4 deletions lib/openai/internal/util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

module OpenAI
module Internal
# rubocop:disable Metrics/ModuleLength

# @api private
module Util
# @api private
Expand Down Expand Up @@ -694,7 +692,5 @@ def decode_sse(lines)
end
end
end

# rubocop:enable Metrics/ModuleLength
end
end