Skip to content

chore: remove stale thread local checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

chore: remove stale thread local checks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions lib/openai/pooled_net_requester.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,33 +85,16 @@ def build_request(request, &)
# @param url [URI::Generic]
# @param blk [Proc]
#
private def with_pool(url, &blk)
private def with_pool(url, &)
origin = OpenAI::Util.uri_origin(url)
th = Thread.current
key = :"#{object_id}-#{self.class.name}-connection_in_use_for_#{origin}"

if th[key]
tap do
conn = self.class.connect(url)
return blk.call(conn)
ensure
conn.finish if conn&.started?
end
end

pool =
@mutex.synchronize do
@pools[origin] ||= ConnectionPool.new(size: @size) do
self.class.connect(url)
end
end

pool.with do |conn|
th[key] = true
blk.call(conn)
ensure
th[key] = nil
end
pool.with(&)
end

# @private
Expand Down