Skip to content

fix!: use descriptive prefixes for enum names that start with otherwise illegal identifiers #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix!: use descriptive prefixes for enum names that start with otherwise illegal identifiers #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/openai/models/batch_create_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class BatchCreateParams < OpenAI::BaseModel
module CompletionWindow
extend OpenAI::Enum

NUMBER_24H = :"24h"
COMPLETION_WINDOW_24H = :"24h"

finalize!

Expand Down
6 changes: 3 additions & 3 deletions lib/openai/models/image_create_variation_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ module ResponseFormat
module Size
extend OpenAI::Enum

NUMBER_256X256 = :"256x256"
NUMBER_512X512 = :"512x512"
NUMBER_1024X1024 = :"1024x1024"
SIZE_256X256 = :"256x256"
SIZE_512X512 = :"512x512"
SIZE_1024X1024 = :"1024x1024"

finalize!

Expand Down
6 changes: 3 additions & 3 deletions lib/openai/models/image_edit_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ module ResponseFormat
module Size
extend OpenAI::Enum

NUMBER_256X256 = :"256x256"
NUMBER_512X512 = :"512x512"
NUMBER_1024X1024 = :"1024x1024"
SIZE_256X256 = :"256x256"
SIZE_512X512 = :"512x512"
SIZE_1024X1024 = :"1024x1024"

finalize!

Expand Down
10 changes: 5 additions & 5 deletions lib/openai/models/image_generate_params.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ module ResponseFormat
module Size
extend OpenAI::Enum

NUMBER_256X256 = :"256x256"
NUMBER_512X512 = :"512x512"
NUMBER_1024X1024 = :"1024x1024"
NUMBER_1792X1024 = :"1792x1024"
NUMBER_1024X1792 = :"1024x1792"
SIZE_256X256 = :"256x256"
SIZE_512X512 = :"512x512"
SIZE_1024X1024 = :"1024x1024"
SIZE_1792X1024 = :"1792x1024"
SIZE_1024X1792 = :"1024x1792"

finalize!

Expand Down
2 changes: 1 addition & 1 deletion rbi/lib/openai/models/batch_create_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module OpenAI
OrSymbol =
T.type_alias { T.any(Symbol, String, OpenAI::Models::BatchCreateParams::CompletionWindow::TaggedSymbol) }

NUMBER_24H = T.let(:"24h", OpenAI::Models::BatchCreateParams::CompletionWindow::TaggedSymbol)
COMPLETION_WINDOW_24H = T.let(:"24h", OpenAI::Models::BatchCreateParams::CompletionWindow::TaggedSymbol)

sig { override.returns(T::Array[OpenAI::Models::BatchCreateParams::CompletionWindow::TaggedSymbol]) }
def self.values
Expand Down
6 changes: 3 additions & 3 deletions rbi/lib/openai/models/image_create_variation_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ module OpenAI
OrSymbol =
T.type_alias { T.any(Symbol, String, OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol) }

NUMBER_256X256 = T.let(:"256x256", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)
NUMBER_512X512 = T.let(:"512x512", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)
NUMBER_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)
SIZE_256X256 = T.let(:"256x256", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)
SIZE_512X512 = T.let(:"512x512", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)
SIZE_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol)

sig { override.returns(T::Array[OpenAI::Models::ImageCreateVariationParams::Size::TaggedSymbol]) }
def self.values
Expand Down
6 changes: 3 additions & 3 deletions rbi/lib/openai/models/image_edit_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ module OpenAI
TaggedSymbol = T.type_alias { T.all(Symbol, OpenAI::Models::ImageEditParams::Size) }
OrSymbol = T.type_alias { T.any(Symbol, String, OpenAI::Models::ImageEditParams::Size::TaggedSymbol) }

NUMBER_256X256 = T.let(:"256x256", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)
NUMBER_512X512 = T.let(:"512x512", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)
NUMBER_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)
SIZE_256X256 = T.let(:"256x256", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)
SIZE_512X512 = T.let(:"512x512", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)
SIZE_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageEditParams::Size::TaggedSymbol)

sig { override.returns(T::Array[OpenAI::Models::ImageEditParams::Size::TaggedSymbol]) }
def self.values
Expand Down
10 changes: 5 additions & 5 deletions rbi/lib/openai/models/image_generate_params.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,11 @@ module OpenAI
OrSymbol =
T.type_alias { T.any(Symbol, String, OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol) }

NUMBER_256X256 = T.let(:"256x256", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
NUMBER_512X512 = T.let(:"512x512", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
NUMBER_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
NUMBER_1792X1024 = T.let(:"1792x1024", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
NUMBER_1024X1792 = T.let(:"1024x1792", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
SIZE_256X256 = T.let(:"256x256", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
SIZE_512X512 = T.let(:"512x512", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
SIZE_1024X1024 = T.let(:"1024x1024", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
SIZE_1792X1024 = T.let(:"1792x1024", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)
SIZE_1024X1792 = T.let(:"1024x1792", OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol)

sig { override.returns(T::Array[OpenAI::Models::ImageGenerateParams::Size::TaggedSymbol]) }
def self.values
Expand Down
2 changes: 1 addition & 1 deletion sig/openai/models/batch_create_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module OpenAI
module CompletionWindow
extend OpenAI::Enum

NUMBER_24H: :"24h"
COMPLETION_WINDOW_24H: :"24h"

def self?.values: -> ::Array[OpenAI::Models::BatchCreateParams::completion_window]
end
Expand Down
6 changes: 3 additions & 3 deletions sig/openai/models/image_create_variation_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ module OpenAI
module Size
extend OpenAI::Enum

NUMBER_256X256: :"256x256"
NUMBER_512X512: :"512x512"
NUMBER_1024X1024: :"1024x1024"
SIZE_256X256: :"256x256"
SIZE_512X512: :"512x512"
SIZE_1024X1024: :"1024x1024"

def self?.values: -> ::Array[OpenAI::Models::ImageCreateVariationParams::size]
end
Expand Down
6 changes: 3 additions & 3 deletions sig/openai/models/image_edit_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ module OpenAI
module Size
extend OpenAI::Enum

NUMBER_256X256: :"256x256"
NUMBER_512X512: :"512x512"
NUMBER_1024X1024: :"1024x1024"
SIZE_256X256: :"256x256"
SIZE_512X512: :"512x512"
SIZE_1024X1024: :"1024x1024"

def self?.values: -> ::Array[OpenAI::Models::ImageEditParams::size]
end
Expand Down
10 changes: 5 additions & 5 deletions sig/openai/models/image_generate_params.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ module OpenAI
module Size
extend OpenAI::Enum

NUMBER_256X256: :"256x256"
NUMBER_512X512: :"512x512"
NUMBER_1024X1024: :"1024x1024"
NUMBER_1792X1024: :"1792x1024"
NUMBER_1024X1792: :"1024x1792"
SIZE_256X256: :"256x256"
SIZE_512X512: :"512x512"
SIZE_1024X1024: :"1024x1024"
SIZE_1792X1024: :"1792x1024"
SIZE_1024X1792: :"1024x1792"

def self?.values: -> ::Array[OpenAI::Models::ImageGenerateParams::size]
end
Expand Down