Repository navigation
Replies: 1 comment
|
This bug cost me 15M tokens while the agent loops and I think it was working. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Context
Symphony's Codex app-server client can receive notifications for both the root thread and spawned sub-agent threads on the same connection. The current handler accepts any
turn/completednotification as completion of the active root turn.In a multi-agent requirement-estimation run, a child estimator completing caused Symphony to return success for the parent session immediately, interrupt the remaining child agent, and redispatch the issue. A child
thread/status/changedtransition to idle is not itself terminal; the actual completion gate is the unscopedturn/completedhandler.Proposed fix
thread_idandturn_idthrough the app-server receive loop.turn/completed,turn/failed, orturn/cancelledterminate the run when both IDs match.SPEC.md.Filtering only
thread/status/changedis insufficient becauseturn/completedis the actual completion signal. Accepting legacy unscoped completions is also unsafe once child-agent events share the stream.Regression coverage
The new test streams these events in order:
Existing fake app-server fixtures were updated to use the current v2 payload shape with
params.threadIdandparams.turn.id.Review links
PR creation is currently limited to collaborators, so I am posting the completed change here for maintainer review. A collaborator can fetch and cherry-pick it with:
Validation
mise exec -- make allAll reactions