Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify package installation by removing ffmpeg cli install #99

Closed
wants to merge 3 commits into from

Conversation

fcakyon
Copy link
Contributor

@fcakyon fcakyon commented Sep 24, 2022

edit: you no longer have to accept this PR, just created a new package including this feature: https://github.com/fcakyon/pywhisper

This PR reaplaces ffmpeg cli tool + ffmpeg-python package with moviepy package without any difference in audio waveform values.

This PR removes the external cli tool dependency and simplifies installation since pip install would be enough.

I have tested with tests/jfk.flac file and load_audio() output is exactly same as before:

dtype: dtype('float32')
max: 0.78271484
min: -0.7235718
shape: (176000,)
size: 176000

Also tested with a 1h43min video, works without any issues.

moviepy: https://github.com/Zulko/moviepy

@fcakyon fcakyon changed the title remove ffmpeg cli dependency by using moviepy simplify package installation by using moviepy Sep 24, 2022
@fcakyon fcakyon changed the title simplify package installation by using moviepy simplify package installation by removing ffmpeg cli install Sep 24, 2022
@jongwook
Copy link
Collaborator

Thanks for the suggestion (and for the other PRs!) moviepy also uses ffmpeg through the command line, indirectly via imageio. Given that we won't need all the image/movie-specific features, ffmpeg-python seems to be a leaner choice.

@jongwook jongwook closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants