-
-
Notifications
You must be signed in to change notification settings - Fork 255
fix: ambigious tilde specifier requires-python with--meta=uv
#1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ambigious tilde specifier requires-python with--meta=uv
#1321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
--meta=uv
That was fast, thanks @dbanty! |
> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - ambigious tilde specifier requires-python with`--meta=uv` (#1321) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
description = "A client library for accessing Test 3.1 Features" | ||
authors = [] | ||
requires-python = "~=3.9" | ||
requires-python = ">=3.9,<4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When evaluating requires-python ranges for dependencies, uv only considers lower bounds and ignores upper bounds entirely. For example,
>=3.8, <4
is treated as>=3.8
I think we should consider dropping the upper bound from the template due to the various issues it's caused and that some tools ignore it anyway.
This might be a holdover from when this package was more Poetry-focused and Poetry used to by default put a <4
upper bound on new projects created with it? They've since stopped doing that, so I think we should consider doing the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, seems like there will never be a Python 4 anyway 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clients generated like this:
Generate these warnings during installation with
uv
: