Skip to content

fix: ambigious tilde specifier requires-python with--meta=uv #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: ambigious tilde specifier requires-python with--meta=uv #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion end_to_end_tests/metadata_snapshots/uv.pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "test-3-1-features-client"
version = "0.1.0"
description = "A client library for accessing Test 3.1 Features"
authors = []
requires-python = "~=3.9"
requires-python = ">=3.9,<4.0"
Copy link
Collaborator

@johnthagen johnthagen Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When evaluating requires-python ranges for dependencies, uv only considers lower bounds and ignores upper bounds entirely. For example, >=3.8, <4 is treated as >=3.8

I think we should consider dropping the upper bound from the template due to the various issues it's caused and that some tools ignore it anyway.

This might be a holdover from when this package was more Poetry-focused and Poetry used to by default put a <4 upper bound on new projects created with it? They've since stopped doing that, so I think we should consider doing the same.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, seems like there will never be a Python 4 anyway 😋

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme = "README.md"
dependencies = [
"httpx>=0.23.0,<0.29.0",
Expand Down
2 changes: 1 addition & 1 deletion openapi_python_client/templates/pyproject_uv.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "{{ project_name }}"
version = "{{ package_version }}"
description = "{{ package_description }}"
authors = []
requires-python = "~=3.9"
requires-python = ">=3.9,<4.0"
readme = "README.md"
dependencies = [
"httpx>=0.23.0,<0.29.0",
Expand Down
Loading