Skip to content

Conversation

kolyshkin
Copy link
Contributor

As the final go 1.16 is released, rc1 is no longer available.

This fixes our CI.

As the final go 1.16 is released, rc1 is no longer available.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

Can we merge this one quick please? Currently the CI is broken as go-1.16-rc1 is removed from downloads.

@kolyshkin kolyshkin changed the title ci/gha: bump go 1.16-rc1 -> 1.16.x ci/gha: bump go 1.16-rc1 -> 1.16.x; fix gha ci Feb 16, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Feb 16, 2021

@AkihiroSuda ptal

@AkihiroSuda AkihiroSuda merged commit f245a1d into opencontainers:master Feb 17, 2021
@kolyshkin
Copy link
Contributor Author

Marked go 1.16.x jobs as required

@cyphar
Copy link
Member

cyphar commented Feb 17, 2021

Can we switch to 1.x and tip (or beta) rather than having to update the GHA with each Go release? We might want to keep some older versions in the GHA but I'd prefer to not have to do this every time if possible.

@thaJeztah
Copy link
Member

We might want to keep some older versions in the GHA

Those older versions would have to be updated if a new Go version is released (assuming support is "latest + previous"), or did you want to run "latest" + <some fixed minimal version>" ?

I'm slightly concerned that 1.x makes it somewhat unpredictable what version a pull request ran on (and adding support for a new Go version may still need to be a conscious decision)

@cyphar
Copy link
Member

cyphar commented Feb 17, 2021

IMHO we should be testing whether CI fails if you build HEAD with a new Go version, we don't really have the concept of a "supported Go version" in runc in the same way that exists in Docker. The issue is we probably want to have latest + previous (maybe + one fixed minimal version), but I think having 1.x strictly improves the situation even if we end up regularly updating the GHA configuration -- at the very least we immediately know if a new Go version breaks runc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants