Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in build logic #197

Merged
merged 11 commits into from Jun 17, 2019
Merged

Minor fixes in build logic #197

merged 11 commits into from Jun 17, 2019

Conversation

native-api
Copy link
Contributor

@native-api native-api commented May 2, 2019

Various noncritical tidbits that have been bugging me. See commit messages for details.

@native-api
Copy link
Contributor Author

native-api commented May 4, 2019

The failures in Linux are due to network problems.

@native-api
Copy link
Contributor Author

native-api commented May 9, 2019

Fails for 3.7 in MacOS are a CMake problem. Something changed in 3.7.3 library layout and CMake cannot find the library. The last release was built against 3.7.0.

…support

This reverts commit d4a5198.

cmake 3.14 can't find py3 installation when "python" points to Python 3 while cmake 3.9 can
@native-api
Copy link
Contributor Author

native-api commented Jun 17, 2019

It turns out, CMake 3.9 preinstalled in xcode8.3 does not have this problem, only later versions do.

@skvark
Copy link
Member

skvark commented Jun 17, 2019

Thanks. This looks ok, I'll merge if you don't have any additional changes coming in.

@native-api
Copy link
Contributor Author

native-api commented Jun 17, 2019

if you don't have any additional changes coming in.

Not yet. Not yet. :-)

@skvark
Copy link
Member

skvark commented Jun 17, 2019

👍 Please create new PR for new changes.

@skvark skvark merged commit da7d022 into opencv:master Jun 17, 2019
@native-api native-api deleted the fix_detection branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants