Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for scaling up a function #13

Closed
ivanayov opened this issue Sep 20, 2018 · 5 comments
Closed

Add test for scaling up a function #13

ivanayov opened this issue Sep 20, 2018 · 5 comments

Comments

@ivanayov
Copy link
Contributor

Use /system/scale-function for scaling .

Test cases:
1x without limits
1x with limits
1x autoscaling disabled
1x 0 to 1 replicas

@ivanayov
Copy link
Contributor Author

Derek assign: me

@alexellis
Copy link
Member

Let's do the first PR where we scale using the manual endpoint then check the API for how many replicas we expected. Once that's merged, we can look at the next scenario to cover.

@ivanayov
Copy link
Contributor Author

@alexellis I'm now on the TODO list from #14

@ivanayov
Copy link
Contributor Author

After re-running the test several times, I consider random behaviour regarding labels and number of replicas created. Working to fix it.

@ivanayov
Copy link
Contributor Author

Scaling limit restrictions are ignored when calling /system/scale-function.
Tested manually separately from the test. I'm going to remove the labels from the code for now and we can consider this as an separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants