Add test for scaling up a function #14
Conversation
ivanayov
force-pushed
the
ivanayov/scaling-test
branch
2 times, most recently
from
4646983
to
75bfda0
Compare
This adds autoscaling test for the usecases when there are no scaling limits configured Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
ivanayov
force-pushed
the
ivanayov/scaling-test
branch
from
75bfda0
to
3d55cee
Compare
|
|
||
| invoke(t, functionRequest.Service, emptyQueryString, http.StatusOK) | ||
|
|
||
| err := scale(t, functionRequest.Service, "10") |
There was a problem hiding this comment.
I think 10 is too high for a CI machine, just going from 1 to two would be fine.
|
|
||
| } | ||
|
|
||
| func scale(t *testing.T, fnName string, replicas string) error { |
There was a problem hiding this comment.
It'd be better not to pass testing.T and then deal with any testing stuff in the caller.
There was a problem hiding this comment.
Fixed in PR#24.
I noticed that other functions have testing.T parameters. Examples in deploy_test.go are
- line 267, deploy()
- 283, list()
- 308, get()
That might explain why @ivanayov did something similar.
| return fmt.Errorf("Failed to POST request %s to endpoint %s. Error: %t", request, endpoint, err) | ||
| } | ||
|
|
||
| if res.StatusCode != 200 && res.StatusCode != 202 { |
There was a problem hiding this comment.
Rather than integers use http.StatusAccepted etc
| } | ||
|
|
||
| if res.StatusCode != 200 && res.StatusCode != 202 { | ||
| return fmt.Errorf("Failed scaling function on endpoint: %s. %d %s", endpoint, res.StatusCode, res.Body) |
There was a problem hiding this comment.
Errors start with a lowercase letter
|
I can work on finishing this one. |
|
Thank you 🙏 |
|
I found an example of @Waterdrips fixing someone else's fork here: openfaas/openfaas-cloud#531 It seems like the original PR was closed and a new one was created. I'll attempt something similar. @alexellis, unless you had another way in mind, I think this PR can be closed for PR #24. |
You could add "Closes #14" in the PR Description #24 (comment) |
|
This was resolved in #29 |
This adds autoscaling test for the usecases when there are no
scaling limits configured
Signed-off-by: Ivana Yovcheva (VMware) iyovcheva@vmware.com
Resolves #13