Fix snapshot key error

[shivabohemian]

When obtaining the container information fails, the key for deleting the snapshot is incorrect.

Description

Motivation and Context

• I have raised an issue to propose this change this is required

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

• I've read the CONTRIBUTION guide
• My commit message has a body and describe how this was tested and why it is required.
• I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

• My code follows the code style of this project.
• I have added tests to cover my changes.

Docs:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[alexellis]

Can you link to where this key is used in the codebase?

Please see the contributing guide. Where is the issue that shows how to reproduce and observe this problem?

[shivabohemian]

Ok, you can look here and here.
In some cases, deleting a snapshot with the wrong key will fail, resulting in the failure to create the faas container the next time.

[alexellis]

Needs more info and an issue to reproduce the problem.

[alexellis]

The solution looks correct so I'll merge it, but we need issues to be created before PRs, and proof of the issue, plus proof of the fix.

[alexellis]

Feel free to test again, and see if your snapshots are being cleared up:

https://github.com/openfaas/faasd/releases/tag/0.18.7

[shivabohemian]

After I made changes to the code and tested it, things are indeed running normally now. Previously, an error like the one below would occur and it would require manual deletion of the snapshot in order to start successfully.
Unexpected status: 400, message: unable to create container: nats, error: snapshot "nats-snapshot": already exists.

[alexellis]

That's great, thanks for picking this up.

What kinds of things are you using faasd for?

Would you like to meet us at the weekly call and chat more? https://docs.openfaas.com/community/#weekly-office-hours