Privilégie la notion de logement conventionné pour la détermination du secteur APL #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
reviewed
Nov 26, 2018
| @@ -25,6 +25,7 @@ | |||
| relative_error_margin: 0.001 | |||
| input_variables: | |||
| statut_occupation_logement: locataire_hlm | |||
| logement_conventionne: 1 | |||
There was a problem hiding this comment.
C'est une variable de type bool, il vaut mieux utiliser (ici et dans les autres tests)
logement_conventionne: true
(également à corriger dans tests/formulas/aides_logement_foyer.yaml)
Morendil
changed the title
|
Merci pour les corrections @mtifarine ! Avant d'approuver je vais demander à @guillett ou @alexsegura de vérifier si cela n'entraîne pas de (nouvelles) régressions pour Mes Aides. |
|
@mtifarine Merci pour les précisions sur la RLS, je vais m'assurer de la cohérence avec #1217 en prenant le rebase et le merge. (L'idée est que l'éligibilité est évaluée dans la variable RLS.) |
Morendil
force-pushed
the
msa_remplace_notion_locataire_hlm
branch
from
0f4f27c to
3453729
Compare
Morendil
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model/prestations/aides_logement.