-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parameters optional #2
Labels
Comments
Merged
lwgray
added a commit
to lwgray/vidsum
that referenced
this issue
Oct 1, 2017
- Requiring video-file and subtitle cmdline args interfere with downloading Youtube videos - args.video_file is the incorrect parameter to be placed in 'download_url' function call at line 118 Github issue OpenGenus#1 Github issue OpenGenus#2 Github issue OpenGenus#4
This was referenced Oct 1, 2017
This issue seems to have been fixed, but it isn't closed. Is there something left to be done? |
This issue has been resolved 👍 |
@AdiChat Should this issue be closed? |
Yes 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Make parameters
video-file
andsubtitle-file
optional.Line 107 :
parser.add_argument('-i', '--video-file', help="Input video file", required=True)
should becomeparser.add_argument('-i', '--video-file', help="Input video file")
Same goes with Line 108
This will solve issue #1
The text was updated successfully, but these errors were encountered: