Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parameters optional #2

Closed
AdiChat opened this issue Sep 30, 2017 · 4 comments
Closed

Make parameters optional #2

AdiChat opened this issue Sep 30, 2017 · 4 comments
Labels
hacktoberfest solves bug

Comments

@AdiChat
Copy link
Member

AdiChat commented Sep 30, 2017

Make parameters video-file and subtitle-file optional.

Line 107 : parser.add_argument('-i', '--video-file', help="Input video file", required=True) should become parser.add_argument('-i', '--video-file', help="Input video file")

Same goes with Line 108

This will solve issue #1
@grimd34th grimd34th mentioned this issue Oct 1, 2017
Merged
lwgray added a commit to lwgray/vidsum that referenced this issue Oct 1, 2017
@lwgray
fix: Make cmdline ARGS opt and change 'download_url' param
6cbaa4e 
- Requiring video-file and subtitle cmdline args interfere with downloading Youtube videos
- args.video_file is the incorrect parameter to be placed in 'download_url' function call at line 118
Github issue OpenGenus#1
Github issue OpenGenus#2
Github issue OpenGenus#4
This was referenced Oct 1, 2017
Merged
Closed
@shriakhilc
Copy link
Contributor

This issue seems to have been fixed, but it isn't closed. Is there something left to be done?

@AdiChat
Copy link
Member Author

AdiChat commented Oct 3, 2017

This issue has been resolved 👍

@lwgray
Copy link
Contributor

lwgray commented Oct 4, 2017

@AdiChat Should this issue be closed?

@AdiChat
Copy link
Member Author

AdiChat commented Oct 4, 2017

Yes 😄

@AdiChat AdiChat closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest solves bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lwgray @AdiChat @shriakhilc