Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release 5.7.0 #1680

Merged
merged 34 commits into from
Apr 20, 2021
Merged

build: release 5.7.0 #1680

merged 34 commits into from
Apr 20, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Apr 20, 2021 •
edited
Loading

Release cannot be rolled back due to API endpoint changes

Improvements

  • refactor: duplicate adminform submissions to /api/v3 endpoint #1641
  • refactor: migrate GET /submission to new endpt #1645
  • refactor(admin-form-api): duplicate adminform form endpoints for /api/v3i #1635
  • refactor(email-submission/controller): refactored email submission #1594
  • refactor(feedback-api): duplicate adminform feedback endpoints for /api/v3 #1589
  • refactor(frontend-api): duplicate frontend client endpoints to new /api/v3 router #1574
  • refactor(PublicFormRoutes): duplicate /publicform to /api/v3 endpoints #1588
  • test: fix possibly flaky test by assigning constant to date #1668

Fixes

  • fix: jest memory leak #1659
  • fix: loosen validation for sg home numbers #1663
  • fix: merge conflict from merging with develop 9f0930e

Dependency Updates

  • fix(deps): bump aws-sdk from 2.884.0 to 2.885.0 #1636
  • fix(deps): bump aws-sdk from 2.885.0 to 2.886.0 #1648
  • fix(deps): bump aws-sdk from 2.886.0 to 2.888.0 #1656
  • fix(deps): bump fp-ts from 2.10.0 to 2.10.2 #1653
  • fix(deps): bump fp-ts from 2.10.2 to 2.10.3 #1677
  • fix(deps): bump fp-ts from 2.9.5 to 2.10.0 #1646
  • fix(deps): bump helmet from 4.4.1 to 4.5.0 #1665
  • fix(deps): bump opossum from 6.0.0 to 6.0.1 #1658
  • chore(deps-dev): bump @types/node from 14.14.37 to 14.14.41 #1657
  • chore(deps-dev): bump concurrently from 6.0.1 to 6.0.2 #1638
  • chore(deps-dev): bump core-js from 3.10.1 to 3.10.2 #1678
  • chore(deps-dev): bump csv-parse from 4.15.3 to 4.15.4 #1660
  • chore(deps-dev): bump date-fns from 2.20.2 to 2.20.3 #1637
  • chore(deps-dev): bump date-fns from 2.20.3 to 2.21.0 #1649
  • chore(deps-dev): bump date-fns from 2.21.0 to 2.21.1 #1662
  • chore(deps-dev): bump eslint-config-prettier from 8.1.0 to 8.2.0 #1639
  • chore(deps-dev): bump eslint-plugin-prettier from 3.3.1 to 3.4.0 #1661
  • chore(deps-dev): bump jest-mock-axios from 4.3.0 to 4.4.0 #1667
  • chore(deps-dev): bump ts-jest from 26.5.4 to 26.5.5 #1654
     

orbitalsqwib and others added 30 commits April 13, 2021 13:22
@orbitalsqwib
refactor(frontend-api): duplicate frontend client endpoints to new /a…
fffd972 
…pi/v3 router (#1574)

* refactor(frontend-api): duplicate frontend client endpoints to new /api/v3 router

- duplicate frontend client endpoints functionality and update them to use
the new api v3 routes
- update v3 router to use new endpoints
- update frontend api calls to use new endpoints

* refactor(frontend-api): use updated frontend handlers

* refactor(frontend-api): clean up routes and update comments

* fix(frontend-api): fix /features route and clean up routes
@orbitalsqwib
refactor(feedback-api): duplicate adminform feedback endpoints for /…
f876c43 
…api/v3 (#1589)

* refactor(settings-api): shard admin routes into separate files

* refactor(feedback-api): duplicate adminform feedback endpoints to new /api/v3 router

- duplicate adminform feedback endpoint functionalities and update them to use the
new api v3 routes
- update v3 router to use new endpoints
- update frontend api calls to use new endpoints

* fix(feedback-api): add auth middleware back to main admin router

* test(feedback-api): update test router to use real root route

* refactor(forms-routes): fix tests and clean up endpoints

- remove duplicated auth middleware from feedback endpoints
- import index level router for form-route tests to account for
shifted auth middleware
- shard index into admin-forms.routes and index to follow convention

* ref(feedback-api): rename handle-get-form-feedbacks to feedback
@mantariksh
Merge pull request #1632 from opengovsg/release-v5.6.0
85782d7 
chore: merge release v5.6.0 back to develop
@dependabot
fix(deps): bump aws-sdk from 2.884.0 to 2.885.0 (#1636)
35c5fcc 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.884.0 to 2.885.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.884.0...v2.885.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump date-fns from 2.20.2 to 2.20.3 (#1637)
bdcc156 
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.20.2 to 2.20.3.
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md)
- [Commits](date-fns/date-fns@v2.20.2...v2.20.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint-config-prettier from 8.1.0 to 8.2.0 (#1639)
ac4dde3 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.1.0 to 8.2.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v8.1.0...v8.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump concurrently from 6.0.1 to 6.0.2 (#1638)
7359413 
Bumps [concurrently](https://github.com/kimmobrunfeldt/concurrently) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/kimmobrunfeldt/concurrently/releases)
- [Commits](kimmobrunfeldt/concurrently@v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@seaerchin
refactor: duplicate adminform submissions to /api/v3 endpoint (#1641)
132d5fe 
* style(admin-forms/feedback): fixed misspelling of admin

* refactor(admin-form/controller): combined validator into handleCountFormSubmission

* refactor(admin-forms/submissions): duplicates over submissions over to new routes

* refactor(submissions/client/factory): removed FE callsite

* fix(admin-forms/submission): adds joi/date to base joi

* test(admin-forms/submissions): adds test from old route

* fix(submissions/client/factory): fixed endpoints for adminform

* refactor(encrypt-submission): combines validation together with handler

* test(encrypt-submission): fixes controller tests due to atomic export for validator + handler

* test(admin-forms/submissoins): ports over tests for submissions/download

* refactor(submissions/client/factory): changed frontend to call new backend api

* chore(admin-forms/submissions): renamed file from submission to submissions

* style(submissions/client/factory): combined api and admin form prefix into one

* fix(admin-form/encrypt-submission): fixed date validation to be min instead of greater

* test(admin-forms): added tests for date validation to submissions/count and submissions/download

as start date can be equal to end date, the hotfix in #1634 was ported over. additionally, an extra
unit test for /submissions/download was added to ensure that the same issue does not plague it

* style(admin-forms/submissions): changed submission to be submissionS

* docs(admin-forms/submissions): fixed comment
@karrui
Merge branch 'develop' into release-v5.6.1
2eec89e
@dependabot
chore(deps-dev): bump date-fns from 2.20.3 to 2.21.0 (#1649)
3034901 
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.20.3 to 2.21.0.
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md)
- [Commits](date-fns/date-fns@v2.20.3...v2.21.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui
fix: merge conflict from merging with develop
9f0930e
@dependabot
fix(deps): bump aws-sdk from 2.885.0 to 2.886.0 (#1648)
0ec8966 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.885.0 to 2.886.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.885.0...v2.886.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump fp-ts from 2.9.5 to 2.10.0 (#1646)
185ab21 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.9.5 to 2.10.0.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](gcanti/fp-ts@2.9.5...2.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@seaerchin
refactor: migrate GET /submission to new endpt (#1645)
bf8e9e6 
* refactor(encrypt-submission): combines validator and controller together as a single export

* test(encrypt-submission/test): fixes tests for getting a submission from query params

* feat(encrypt-submissions/controller): adds new controller method for GET /submissions/submissionId

* test(encrypt-submission/controller): adds tests for getEncryptedResponse

* fix(encrypt-submission/controller): fixes rebase errors

* refactor(encrypt-submission): removed validation from controller as express can validate it

* test(encrypt-submission): renamed getEncryptedResponse to handleGetEncryptedResponse

* feat(admin-forms/submission/routes): adds GET /submissions/:submissionId to new api rooted endpoint

* test(admin-forms/submissions/routes/test): ported over tests from old endpoint; changed to use url

* refactor(submission/client/factory): changed FE callsites

* style(submissions/routes/tests): changed '/admin/forms' to a constant

* docs(encrypt-submission/controller): added jsdoc for deprecation

* docs(encrypt-submissino): adds deprecate marker on routes also
@seaerchin
refactor(PublicFormRoutes): duplicate /publicform to /api/v3 endpoints (
c4599ed 
#1588)

* refactor(public-forms/api): updated endpoints to new /api/v3 endpoitns

* test(public-forms/routes): added integration tests for POST :formId/feedback

* refactor(public-forms/routes): shifts email submission to new v3 Router

* refactor(public-forms/routes): separated routing from middlewares in email form submission

* test(public-forms/routes): copied over email submission tests

* chore(public-forms.routes): fixes imports

* refactor(public-forms): fe now calls new be endpoint; feedback changed to plural

* test(public-forms/routes): changed feedback to feedbacks

* refactor(form-feedback/submissions): changed endpoint which fe queries

* refactor(public-forms/routes): shifted submit encrypted form ot v3/api

* test(public-forms/routes): shifted tests for encrypt submissions to new api/v3

* refactor(public-form/routes): shifted over getpublicform to new v3 api

* style(public-forms/routes): renamed feedbacks to feedback

* refactor(public-form/controller): changed typing to use dto

* test(public-forms/routes): fixes tests

* refactor(form-api): changed to new BE api

* docs(public-forms): fixed comment pointing out plural(?) form of feedback

* fix(form-api): fixed url in new backend call

* style(public-forms/form-api): removed unused variable/removed extra '/' for consistencyt

* refactor(public-forms): collapses validation middleware into handleSubmitFeedback

* test(public-form/controller): fixes test related to collapsing validation

\

* refactor(email-submission): exports submissoin handler together with validation

* refactor(encrypt-submission): exports handler together with validator

* refactor(public-forms/routes): changed endpoints to reflect validation moving into controller

* docs(public-forms/routes): add deprecation warning in jsdoc
@karrui
Merge pull request #1650 from opengovsg/release-v5.6.1
a988244 
chore: merge release v5.6.1 back to develop
@dependabot
chore(deps-dev): bump ts-jest from 26.5.4 to 26.5.5 (#1654)
4f38266 
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 26.5.4 to 26.5.5.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v26.5.4...v26.5.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump fp-ts from 2.10.0 to 2.10.2 (#1653)
fd3ec25 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.10.0 to 2.10.2.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](gcanti/fp-ts@2.10.0...2.10.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump csv-parse from 4.15.3 to 4.15.4 (#1660)
594bd77 
Bumps [csv-parse](https://github.com/wdavidw/node-csv-parse) from 4.15.3 to 4.15.4.
- [Release notes](https://github.com/wdavidw/node-csv-parse/releases)
- [Changelog](https://github.com/adaltas/node-csv-parse/blob/master/CHANGELOG.md)
- [Commits](adaltas/node-csv-parse@v4.15.3...v4.15.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint-plugin-prettier from 3.3.1 to 3.4.0 (#1661)
93c78be 
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui
fix: jest memory leak (#1659)
d52515e 
* fix: stop mongo memory server on test database close

this fixes a memory leak where the server continues running after every test

* test(VfnSvc): fix mem leak by closing test db after suite finishes
@dependabot
fix(deps): bump opossum from 6.0.0 to 6.0.1 (#1658)
e10d6b8 
Bumps [opossum](https://github.com/nodeshift/opossum) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/nodeshift/opossum/releases)
- [Changelog](https://github.com/nodeshift/opossum/blob/main/CHANGELOG.md)
- [Commits](nodeshift/opossum@v6.0.0...v6.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.886.0 to 2.888.0 (#1656)
4ee47d0 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.886.0 to 2.888.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.886.0...v2.888.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@seaerchin
refactor(email-submission/controller): refactored email submission (#…
0d5d7f9 
…1594)

* refactor(email-submission/controller): refactored email submission to be chained

* refactor(email-submission/controller): refactored controller to use new methods

* refactor(spcp.util): removed unused methods

* fix(email-submission): fixed bug caused by rebasing off develop

* refactor(email-submission): add new type and refactored email submission controller to use type

* refactor(email-submission): removed logging utility method

* refactor(email-submission): add explicit type annotation for clarity

* refactor(email-submission/util): adds default argument to email submission object

* docs(email-submission): added docs for not clearing of cookies in error case for submission

* docs(email-submission/controller): fixed typo
@dependabot
chore(deps-dev): bump @types/node from 14.14.37 to 14.14.41 (#1657)
6eb7a51 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.37 to 14.14.41.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump date-fns from 2.21.0 to 2.21.1 (#1662)
c3bcc6c 
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.21.0 to 2.21.1.
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md)
- [Commits](date-fns/date-fns@v2.21.0...v2.21.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump jest-mock-axios from 4.3.0 to 4.4.0 (#1667)
8c02b1f 
Bumps [jest-mock-axios](https://github.com/knee-cola/jest-mock-axios) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/knee-cola/jest-mock-axios/releases)
- [Changelog](https://github.com/knee-cola/jest-mock-axios/blob/master/CHANGELOG.md)
- [Commits](knee-cola/jest-mock-axios@v4.3.0...v4.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump helmet from 4.4.1 to 4.5.0 (#1665)
669581c 
Bumps [helmet](https://github.com/helmetjs/helmet) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/helmetjs/helmet/releases)
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](helmetjs/helmet@v4.4.1...v4.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@orbitalsqwib
refactor(admin-form-api): duplicate adminform form endpoints for /api…
bd98c65 
…/v3i (#1635)

* refactor(admin-form-api): duplicate adminform form endpoints for /api/v3i

- duplicate and update adminform form related endpoints
- duplicate integration tests for new endpoint
- update v3 router to use new endpoints
- update frontend api calls to use new endpoints

* refactor(admin-form-api): remove unneeded joi-date extension

* ref(admin-form-api): remove duplicate user auth middleware from routes

* ref(admin-form-api): remove trailing / for consistency

* ref(admin-form-api): consolidate validators into controller

- shift validators into admin-form controller
- update handler methods to include validators as request handler array
- update controller integration tests
- update old routes to use new handler
- update new routes to use new handler
@karrui
test: fix possibly flaky test by assigning constant to date (#1668)
b5c5c04 
* test: fix possibly flakey test by assigning constant to date

flakey on travis but not on local, this is just an attempt to hopefully fix the flake

* test: remove unnecessary comments
dependabot bot and others added 4 commits April 19, 2021 17:50
@dependabot
fix(deps): bump fp-ts from 2.10.2 to 2.10.3 (#1677)
440e5e2 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.10.2 to 2.10.3.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](gcanti/fp-ts@2.10.2...2.10.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump core-js from 3.10.1 to 3.10.2 (#1678)
0d2594f 
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.10.1 to 3.10.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.10.2/packages/core-js)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
fix: loosen validation for sg home numbers (#1663)
0041fca 
* fix: loose home number validation for sg numbers

* chore: add test case

* docs: add docs on singapore national numbering plan

* refactor: reuse startsWithSgPrefix
@tshuli
chore: bump version to 5.7.0
6f91f00
@tshuli tshuli changed the base branch from develop to release April 20, 2021 04:00
@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited by mantariksh
Loading

@mantariksh

Tests

Intranet IE11 runthrough

  • Create email mode form with all fields and custom start/end page. Activate and submit form. Check that you can receive responses in your intranet inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields and custom start/end page. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments for individual fields can be downloaded from Data tab in storage mode.
  • Attachment ZIP for submission can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited
Loading

@tshuli
duplicate adminform submissions to /api/v3 endpoint

  • Create a storage mode form with attachment fields. Publish the form, go to it and submit a few times with attachments.
    • Go to the admin panel and click on data. There should be x responses to date. Click on export and perform both actions. The files should be downloaded successfully.
    • Change the date range to a date in the past without submissions. Verify that you are unable to export csv (both with/without attachments)
    • Change the date change to a valid date range and try to export csv again (with and without). The files should be downloaded successfully

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited by karrui
Loading

@karrui
migrate GET /submission to new endpt

  • Create a new storage mode form and make it public. Go to the form and submit a few responses. Go to the admin panel and click on data and click on any response. The panel should be populated with the information of the responses

duplicate adminform form endpoints for /api/v3i

  • Check that the current logged in user can see the list of their forms in their dashboard (GET /api/v3/admin/forms/)
  • Check that you can create a new form (POST /api/v3/admin/forms)
  • Check that you can duplicate a form (POST /api/v3/admin/forms/:formId/duplicate)
  • Check that you can delete a form (DELETE /api/v3/admin/forms/:formId)
  • Check that you can transfer ownership of a form (POST /api/v3/admin/forms/:formId/collaborators/transfer-owner)

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited by karrui
Loading

@karrui
refactored email submission

  • 1. Create a single field form without authentication and set its mode to email. Submitting the form should have the field data
  • 2. Create a single field SP form and set its mode to email. Submitting the form should have the field data
  • 3. Create a single field CP form and set its mode to email. Submitting the form should have the field data
  • 4. Create a single field MyInfo form and set its mode to email. Submitting the form should have the field data
  • 5. Submit storage mode form to email mode endpoint. This should fail with 400 Bad Request
  • 6. Submit form which has been made private
  • 7. Submit form which has been archived
  • 8. Submit captcha-enabled form without captcha
  • 9. Submit captcha-disabled form
  • 10. Submit form which has exceeded submission limit. This should fail with 404 Not Found
  • 11. Create a form with a yes/no field. Submit the form with the yes/no field answer changed to an invalid value (eg: 'INVALID'). This should fail with 400 Bad Request
  • 12. Create multiple email fields with email confirmation, check that the correct confirmation email is sent for each one
  • 13. Create a form with an attachment field. Submit form with a non-existent attachment. This should fail with 400 Bad Request

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited
Loading

@tshuli
duplicate adminform feedback endpoints for /api/v3

  • Create a new form, submit a new response, then submit feedback for the form
    Return to the form admin feedback section
  • Check that the feedback can be successfully retrieved (GET /api/v3/admin/forms/:formId/feedback returns 200)
  • Check that the form feedback count is correct (GET /api/v3/admin/forms/:formId/feedback/count returns 200)
  • Check that the feedback export function works (GET /api/v3/admin/forms/:formId/feedback/download returns 200)
  • Check that calling GET /api/v3/admin/forms/:formId/feedback without logging in results in a 401 Unauthorized error
  • Check that calling PATCH /api/v3/admin/forms/:formId/settings without logging in results in a 401 Unauthorized error

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited
Loading

@tshuli
duplicate frontend client endpoints to new /api/v3 router

  • Check that feature requests return 200 on the /api/v3/client/features on landing page
  • Check that form redirects work by accessing a form from a form share link (/api/v3/client/redirect)
  • Test /api/v3/client/analytics/google
  • Test /api/v3/client/environment

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited by karrui
Loading

@karrui
duplicate /publicform to /api/v3 endpoints

NOTE: Attempt the below tests in all auth types

  • Create a normal (NIL Auth) email mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a SP email mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a CP email mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a MyInfo email mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a normal (NIL Auth) storage mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email responses page while the feedback should show up in the admin panel
  • Create a SP storage mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a CP storage mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
  • Create a MyInfo storage mode form with a few fields and publish it. Open the form and fill in the form together with feedback. The responses should show up in email while the feedback should show up in the admin panel
    MyInfo-specific
    • no myinfo in storage mode
  • Create an email mode form and publish it. When signing in using MockPass, deny authentication. The form should not have been signed in and there should be an error message with MyInfo error displayed

@tshuli
Copy link
Contributor Author

tshuli commented Apr 20, 2021 •
edited by seaerchin
Loading

@seaerchin
loosen validation for sg home numbers

  • Create form with home number field. Check that the number 66665555 can be successfully submitted.

@tshuli tshuli merged commit 0c9f0c4 into release Apr 20, 2021
@karrui karrui deleted the release-5.7.0 branch August 17, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tshuli @mantariksh @orbitalsqwib @seaerchin @karrui