-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the interrupt vector table in the documentation #273
base: main
Are you sure you want to change the base?
Update the interrupt vector table in the documentation #273
Conversation
@@ -4,17 +4,18 @@ Exceptions and Interrupts | |||
========================= | |||
|
|||
Ibex implements trap handling for interrupts and exceptions according to the RISC-V Privileged Specification, version 1.11. | |||
(Is it fully compatible with `RISC-V Privileged Specification, version 1.12 <https://drive.google.com/file/d/1EMip5dZlnypTk7pt4WWUKmtjUKTOkBqh/view>`?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is always some confusion about version of RISC-V specs, but I do not believe this is correct. According to the CV32E20 Specification (not to be confused with this User Manual), the target privileged specification for the CV32E20 is The RISC-V Instruction Set Manual, Volume II: Privileged Architecture, Document Version 20211203
, which I believe is v.1.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would gladly put a reference to the correct instruction set manual if you point me to the correct version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec for the above version of the priv spec has been added to the RISC-V Technical Specifications Archive (link).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, the CV32E20 specification points to The RISC-V Instruction Set Manual, Volume II: Privileged Architecture, Document Version 20211203
, but there I couldn't find something that said the version v1.xy .
For now I will put the reference to the link you provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Hi @DanieleParravicini-Synthara. I recommend that we have a (virtual) in-person discussion with @davideschiavone and @MarioOpenHWGroup before we proceed much future with this PR. In the meantime, you will need to be covered by the Eclipse Contributor Agreement before any PRs from you can be accepted. As Synthara is an OpenHW Group member, it is best for you to use a GitHub repo associated with your employer, rather than a person account. |
Will change the signature |
b148d76
to
897cda2
Compare
Removes the reference to the boot_addr_i+0x80 that was coming from legacy documentation and substitute with boot_addr_i where necessary.
Adds a tentative description of the interrupt vector table. That has to be reviewed and adjusted.
897cda2
to
2a9f3c6
Compare
Hello @MikeOpenHWGroup, I changed the signature of all the commits. |
In the meanwhile I will ask to complete the ECA |
d6aaf42
to
e022a30
Compare
Hi @DanieleParravicini. I see that you are now properly covered by the ECA using your Synthara credentials. However, there are still at least two commits in this PR from non-Synthata credentials and these will block the merge. You have two options:
|
Hey @MikeOpenHWGroup, sorry for the mistake. They should be rebased now |
The PR itself is not much but I hope it can help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @DanieleParravicini-Synthara
So you think that I got this right? |
No description provided.