8301820: C4819 warnings were reported on Windows

[YaSuenag]

C4819 warnings were reported when I tried to build JDK on Windows with VS2022.
This PR contains changes both HotSpot and client libraries. Let me know if they should be separated.

• HotSpot
  • stubGenerator_x86_64_poly.cpp
  • elfFile.hpp
• libfontmanager
  • hb.hh
• libfreetype
  • afblue.c

I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for libfreetype because they are 3rd-party libraries.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301820: C4819 warnings were reported on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12427/head:pull/12427
$ git checkout pull/12427

Update a local copy of the PR:
$ git checkout pull/12427
$ git pull https://git.openjdk.org/jdk pull/12427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12427

View PR using the GUI difftool:
$ git pr show -t 12427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12427.diff

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following labels will be automatically applied to this pull request:

• build
• client
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e7183cfc)

[vidmik]

Out of curiosity, which version of VS 2022 is this?

[YaSuenag]

I uses 17.3.6 (VS Community) on Windows 11 Pro (Japanese locale (CP932))

I saw following message on the console (It is Japanese, sorry...)

d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): error C2220: 次の警告はエラーとして処理されます
d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。

In case of stubGenerator_x86_64_poly.cpp , × in comments cannot be handled in cl.exe. I confirmed that this character cannot be handled iconv -f CP932 -t UTF8, so I replaced it to x (alphabet).

[dholmes-ora]

Sorry Yasumasa, but I'd much prefer to see this split into three sub-tasks (or issues) just so we can keep the issues more clearly separated.

IIUC for stubGenerator_x86_64_poly.cpp we have a multiplication symbol instead of an ascii 'x' (likely pasted from a word processing document).

For elfFile.hpp there are smart-quotes instead of ascii "

Thanks.

[YaSuenag]

@dholmes-ora I splitted this in three sub tasks as #12435, #12436, #12437.
I hope they are reviewed and merged.

So I close this PR (but I do not close this issue on JBS until all subtasks are resolved).