8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

[ArnoZeller]

Unless this test is run as root, it needs sudo privileges. If it gets them, the test runs fine, but leaves a file with root ownership. So jtreg cannot delete it, and you see errors when "make clean" tries to delete it.
It's best that we just don't run the test on OSX if sudo privileges.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13791/head:pull/13791
$ git checkout pull/13791

Update a local copy of the PR:
$ git checkout pull/13791
$ git pull https://git.openjdk.org/jdk.git pull/13791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13791

View PR using the GUI difftool:
$ git pr show -t 13791

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13791.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azeller! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ArnoZeller The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (22e6ea31)

[tstuefe]

Seems reasonable.

[openjdk]

@ArnoZeller This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

Reviewed-by: stuefe, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• ad0e5a9: 8304720: SuperWord::schedule should rebuild C2-graph from SuperWord dependency-graph
• 495f268: 8306966: RISC-V: Support vector cast node for Vector API
• 0dca573: 8301739: AArch64: Add optimized rules for vector compare with immediate for SVE
• 3d3eaed: 8306941: Open source several datatransfer and dnd AWT tests
• 1f57ce0: 8307446: RISC-V: Improve performance of floating point to integer conversion
• 4e4828e: 8307553: Remove dead code MetaspaceClosure::push_method_entry
• 7d58978: 8280031: Deprecate GTK2 for removal
• b5922c3: 8305846: Support compilation in Proc test utility
• 73ac710: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
• e2b1013: 8306326: [BACKOUT] 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects
• ... and 46 more: https://git.openjdk.org/jdk/compare/fc76687c2fac39fcbf706c419bfa170b8efa5747...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[plummercj]

/reviewers 2

[openjdk]

@plummercj
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[plummercj]

Changes look good. Is there a reason why this was not noticed when JDK-8290687 was filed and fixed last year?

[ArnoZeller]

@plummercj : I tried to find out why we did not see it when JDK-8290687 was fixed but I am unable to find a reason :-(.

[ArnoZeller]

@tstuefe and @plummercj
Thanks for the reviews! As I am no Committer I will need a sponsor - would one of you be so kind to sponsor me?

[tstuefe]

/sponsor

[openjdk]

@tstuefe The change author (@ArnoZeller) must issue an integrate command before the integration can be sponsored.

[ArnoZeller]

/integrate

[openjdk]

@ArnoZeller
Your change (at version 22e6ea3) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 5c7ede9.
Since your change was applied there have been 63 commits pushed to the master branch:

• 89b7d07: 8307100: Remove ReferentBasedDiscovery reference discovery policy
• f6ea897: 8306285: Missing file in search test
• 33245d6: 8307517: Add VMErrorCallback infrastructure to extend hs_err dumping
• 7a1cb64: 8293547: Add relaxed add_and_fetch for macos aarch64 atomics
• 68f385c: 8307428: jstat tests doesn't tolerate dash in the O column
• 8bbd264: 8307423: [s390x] Represent Registers as values
• 959e62c: 8307521: Introduce check_oop infrastructure to check oops in the oop class
• ad0e5a9: 8304720: SuperWord::schedule should rebuild C2-graph from SuperWord dependency-graph
• 495f268: 8306966: RISC-V: Support vector cast node for Vector API
• 0dca573: 8301739: AArch64: Add optimized rules for vector compare with immediate for SVE
• ... and 53 more: https://git.openjdk.org/jdk/compare/fc76687c2fac39fcbf706c419bfa170b8efa5747...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @ArnoZeller Pushed as commit 5c7ede9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.