Skip to content

8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 37 additions & 21 deletions test/jdk/jdk/jfr/api/consumer/filestream/TestOrdered.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.List;
import java.util.concurrent.CyclicBarrier;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;

import jdk.jfr.Event;
Expand Down Expand Up @@ -143,28 +144,43 @@ private static void printTimestamp(Instant timestamp) {
}

private static Path makeUnorderedRecording() throws Exception {
CyclicBarrier barrier = new CyclicBarrier(THREAD_COUNT + 1);

try (Recording r = new Recording()) {
r.start();
List<Emitter> emitters = new ArrayList<>();
for (int i = 0; i < THREAD_COUNT; i++) {
Emitter e = new Emitter(barrier);
e.start();
emitters.add(e);
}
// Thread buffers should now have one event each
barrier.await();
// Add another event to each thread buffer, so
// events are bound to come out of order when they
// are flushed
for (Emitter e : emitters) {
e.join();
while (true) {
CyclicBarrier barrier = new CyclicBarrier(THREAD_COUNT + 1);
try (Recording r = new Recording()) {
r.start();
List<Emitter> emitters = new ArrayList<>();
for (int i = 0; i < THREAD_COUNT; i++) {
Emitter e = new Emitter(barrier);
e.start();
emitters.add(e);
}
// Thread buffers should now have one event each
barrier.await();
// Add another event to each thread buffer, so
// events are bound to come out of order when they
// are flushed
for (Emitter e : emitters) {
e.join();
}
r.stop();
Path p = Utils.createTempFile("recording", ".jfr");
r.dump(p);
// Order is only guaranteed within a segment.
int segments = countSegments(p);
if (segments < 2) {
return p;
}
System.out.println("File contains more than one segment (" + segments + "). Retrying.");
}
r.stop();
Path p = Utils.createTempFile("recording", ".jfr");
r.dump(p);
return p;
}
}

private static int countSegments(Path file) throws Exception {
AtomicInteger segments = new AtomicInteger();
try (EventStream es = EventStream.openFile(file)) {
es.onFlush(segments::incrementAndGet);
es.start();
return segments.get();
}
}
}