-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8368732: RISC-V: Detect support for misaligned vector access via hwprobe #27512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@RealFYang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/issue JDK-8368732 |
@RealFYang The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
Webrevs
|
0777aa3
to
077a3ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@Hamlin-Li @DingliZhang : Thanks for the reviews! |
Going to push as commit 538a722. |
@RealFYang Pushed as commit 538a722. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, this is a followup change after JDK-8368366.
According to the latest RISC-V linux hardware probing syscall [1], the performance of misaligned memory accesses has been divided into two cases:
RISCV_HWPROBE_KEY_MISALIGNED_SCALAR_PERF
andRISCV_HWPROBE_KEY_MISALIGNED_VECTOR_PERF
for scalar and vector respectively.This aligns
AlignVector
withRISCV_HWPROBE_KEY_MISALIGNED_VECTOR_PERF
. That is if the misaligned vector access is fast, we setAlignVector
to false in the hope that it will save instructions handling address alignment thus improves performance.This choose to keep the use of
RISCV_HWPROBE_KEY_CPUPERF_0
which is now deprecated and returns similar valuesto
RISCV_HWPROBE_KEY_MISALIGNED_SCALAR_PERF
for backward compatibility with old linux kernels.Manually checked the result on platforms w/wo fast misaligned vector accesses by running:
$java -XX:+PrintFlagsFinal -version | grep AlignVector
[1] https://docs.kernel.org/arch/riscv/hwprobe.html
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27512/head:pull/27512
$ git checkout pull/27512
Update a local copy of the PR:
$ git checkout pull/27512
$ git pull https://git.openjdk.org/jdk.git pull/27512/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27512
View PR using the GUI difftool:
$ git pr show -t 27512
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27512.diff
Using Webrev
Link to Webrev Comment