Skip to content

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Sep 26, 2025

Hi, this is a followup change after JDK-8368366.

According to the latest RISC-V linux hardware probing syscall [1], the performance of misaligned memory accesses has been divided into two cases: RISCV_HWPROBE_KEY_MISALIGNED_SCALAR_PERF and RISCV_HWPROBE_KEY_MISALIGNED_VECTOR_PERF for scalar and vector respectively.

This aligns AlignVector with RISCV_HWPROBE_KEY_MISALIGNED_VECTOR_PERF. That is if the misaligned vector access is fast, we set AlignVector to false in the hope that it will save instructions handling address alignment thus improves performance.

This choose to keep the use of RISCV_HWPROBE_KEY_CPUPERF_0 which is now deprecated and returns similar values
to RISCV_HWPROBE_KEY_MISALIGNED_SCALAR_PERF for backward compatibility with old linux kernels.

Manually checked the result on platforms w/wo fast misaligned vector accesses by running:
$java -XX:+PrintFlagsFinal -version | grep AlignVector

[1] https://docs.kernel.org/arch/riscv/hwprobe.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368732: RISC-V: Detect support for misaligned vector access via hwprobe (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27512/head:pull/27512
$ git checkout pull/27512

Update a local copy of the PR:
$ git checkout pull/27512
$ git pull https://git.openjdk.org/jdk.git pull/27512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27512

View PR using the GUI difftool:
$ git pr show -t 27512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27512.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2025

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368732: RISC-V: Detect support for misaligned vector access via hwprobe

Reviewed-by: mli, dzhang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@RealFYang
Copy link
Member Author

/issue JDK-8368732

@openjdk openjdk bot changed the title RISC-V: Detect support for misaligned vector access via hwprobe 8368732: RISC-V: Detect support for misaligned vector access via hwprobe Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@RealFYang The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 26, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2025

@RealFYang RealFYang marked this pull request as draft September 26, 2025 06:57
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 26, 2025
@RealFYang RealFYang marked this pull request as ready for review September 26, 2025 08:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 26, 2025
Copy link
Member

@DingliZhang DingliZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2025
@RealFYang
Copy link
Member Author

@Hamlin-Li @DingliZhang : Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

Going to push as commit 538a722.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2025
@openjdk openjdk bot closed this Sep 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2025
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@RealFYang Pushed as commit 538a722.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants