Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8274296: Update or Problem List tests which may fail with uiScale=2 on macOS #5687

Closed
wants to merge 1 commit into from
Closed

8274296: Update or Problem List tests which may fail with uiScale=2 on macOS #5687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/jdk/ProblemList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,12 @@ javax/swing/JPopupMenu/4634626/bug4634626.java 8017175 macosx-all
javax/swing/JButton/8151303/PressedIconTest.java 8266246 macosx-aarch64
javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java 8273573 macosx-all

# Several tests which fail on some hidpi systems
java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java 8274106 macosx-aarch64
java/awt/Window/8159168/SetShapeTest.java 8274106 macosx-aarch64
java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java 8274106 macosx-aarch64
javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java 8274106 macosx-aarch64

sanity/client/SwingSet/src/ToolTipDemoTest.java 8225012 windows-all,macosx-all
sanity/client/SwingSet/src/ScrollPaneDemoTest.java 8225013 linux-all
sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java 8265770 macosx-all
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/Dialog/SiblingChildOrder/SiblingChildOrderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
* @bug 8190230 8196360
* @summary [macosx] Order of overlapping of modal dialogs is wrong
* @key headful
* @run main SiblingChildOrderTest
* @run main/othervm -Dsun.java2d.uiScale=1 SiblingChildOrderTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching this tests to scale=1 seems completely wrong. On macos it just tweak the rendering so that bug became invisible due to lost of precision. And now we will run the tests in lowDPI on all other platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If really needed I can file a follow-on to change this test to problem listed on macOS like some of the others .. but this test doesn't look to me like its a pixel precision test ...

*/

import java.awt.Color;
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/Paint/PaintNativeOnUpdate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* @library /lib/client
* @build ExtendedRobot
* @author Sergey Bylokhov
* @run main PaintNativeOnUpdate
* @run main/othervm -Dsun.java2d.uiScale=1 PaintNativeOnUpdate
*/
public final class PaintNativeOnUpdate extends Label {

Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/Window/BackgroundIsNotUpdated/BackgroundIsNotUpdated.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @author Sergey Bylokhov
* @library /lib/client
* @build ExtendedRobot
* @run main BackgroundIsNotUpdated
* @run main/othervm -Dsun.java2d.uiScale=1 BackgroundIsNotUpdated
*/
public final class BackgroundIsNotUpdated extends Window {

Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* certain scenarios
* @bug 8021961
* @author Semyon Sadetsky
* @run main ChildAlwaysOnTopTest
* @run main/othervm -Dsun.java2d.uiScale=1 ChildAlwaysOnTopTest
*/

import javax.swing.*;
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* @bug 6683728
* @summary Tests that a JApplet in a translucent JFrame works properly
* @compile -XDignore.symbol.file=true TranslucentJAppletTest.java
* @run main TranslucentJAppletTest
* @run main/othervm -Dsun.java2d.uiScale=1 TranslucentJAppletTest
*/

import java.awt.*;
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/javax/swing/JTabbedPane/TestBackgroundScrollPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* @key headful
* @bug 8172269 8244557
* @summary Tests JTabbedPane background for SCROLL_TAB_LAYOUT
* @run main TestBackgroundScrollPolicy
* @run main/othervm -Dsun.java2d.uiScale=1 TestBackgroundScrollPolicy
*/

public class TestBackgroundScrollPolicy {
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/javax/swing/plaf/nimbus/TestNimbusBGColor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* @bug 8058704 6789980
* @key headful
* @summary Verifies if Nimbus honor JTextPane and JEditorPane background color
* @run main TestNimbusBGColor
* @run main/othervm -Dsun.java2d.uiScale=1 TestNimbusBGColor
*/
import java.awt.Color;
import java.awt.Dimension;
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* @build Util
* @author Romain Guy
* @summary Tests PRESSED and MOUSE_OVER and FOCUSED state for buttons with Synth.
* @run main bug6276188
* @run main/othervm -Dsun.java2d.uiScale=1 bug6276188
*/
import java.awt.*;
import java.awt.image.*;
Expand Down