Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275197: Remove unused fields in ThaiBuddhistChronology #5917

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 12, 2021

Remove 3 unused HashMap's.
Reported here https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html
I did the similar PR to treetenbp and it was merged ThreeTen/threetenbp#155


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275197: Remove unused fields in ThaiBuddhistChronology

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5917/head:pull/5917
$ git checkout pull/5917

Update a local copy of the PR:
$ git checkout pull/5917
$ git pull https://git.openjdk.java.net/jdk pull/5917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5917

View PR using the GUI difftool:
$ git pr show -t 5917

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5917.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs i18n labels Oct 12, 2021
@turbanoff turbanoff changed the title [PATCH] Remove unused fields in ThaiBuddhistChronology 8275197: Remove unused fields in ThaiBuddhistChronology Oct 13, 2021
@openjdk openjdk bot added the rfr label Oct 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2021

Webrevs

naotoj
naotoj approved these changes Oct 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275197: Remove unused fields in ThaiBuddhistChronology

Reviewed-by: naoto, rriggs, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 54b8870: 8275035: Clean up worker thread infrastructure
  • 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/124f82377ba93359bc59118ee315ba194080fa92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @RogerRiggs, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 13, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 14, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@turbanoff
Your change (at version 923d988) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 11, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

Going to push as commit 1e941de.
Since your change was applied there have been 406 commits pushed to the master branch:

  • 6954b98: 8186670: Implement _onSpinWait() intrinsic for AArch64
  • 3445e50: 8276265: jcmd man page is outdated
  • 0ca0acf: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges
  • b0d7a9d: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
  • 8aae88b: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI
  • c29cab8: 8276112: Inconsistent scalar replacement debug info at safepoints
  • aea0967: 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt
  • ... and 396 more: https://git.openjdk.java.net/jdk/compare/124f82377ba93359bc59118ee315ba194080fa92...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

@RogerRiggs @turbanoff Pushed as commit 1e941de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the unused_HashMap_ThaiBuddhistChronology branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs i18n integrated
4 participants