Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases #148

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 20, 2021

I want to downport this test fix for parity with 11.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/148.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 845799935b794e255dc6434f18bd3cb8ada225eb 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 2696643: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 1e1a2c4: 8270556: Exclude security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA
  • 10bbe2f: 8263531: Remove unused buffer int
  • dff3b7f: 8267459: Pasting Unicode characters into JShell does not work.
  • 2252165: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • 8008d33: 8269304: Regression ~5% in 2005 in b27
  • 7a61e03: 8268347: C2: nested locks optimization may create unbalanced monitor enter/exit code
  • 93f952c: 8269882: stack-use-after-scope in NewObjectA
  • c9a8220: 8268620: InfiniteLoopException test may fail on x86 platforms
  • 23918db: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • ... and 40 more: https://git.openjdk.java.net/jdk11u-dev/compare/f31c90f539fe1b14ec56c94cfc63df2aaf4c1e2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2021

Webrevs

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Jul 22, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 2b3a641.
Since your change was applied there have been 72 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@GoeLin Pushed as commit 2b3a641.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant