8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

[RealCLanger]

This backport just removes a problem list entry, had to be resolved.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/505/head:pull/505
$ git checkout pull/505

Update a local copy of the PR:
$ git checkout pull/505
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 505

View PR using the GUI difftool:
$ git pr show -t 505

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/505.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 65cab1e: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (a8804d28)

[RealCLanger]

@mrserb Maybe you can help me here...?
The test that is un-excluded here does fail on my MacOS 11.6 dev system when I'm running it via make run-test. However, test fails also for jdk/jdk on my system. I make the same observations for #506, #511 and #512... The failures look pretty similar to those described in the bugs. Am I making something wrong? Does it need some special setup? I assume Oracle enabled/fixed these tests and now sees them working...

[mrserb]

I'll take a look tomorrow.

[mrserb]

I have tested it on my macOS 11.6 and it works fine on jdk11 and JDK. The test is small you can just comment out the robot, and type the buttons on the keyboard. Or you can check what the robot typed(it should press "a" then enter).
Probably you have some non-US/EN keyboard layout?

[RealCLanger]

I have tested it on my macOS 11.6 and it works fine on jdk11 and JDK. The test is small you can just comment out the robot, and type the buttons on the keyboard. Or you can check what the robot typed(it should press "a" then enter). Probably you have some non-US/EN keyboard layout?

It seems the Robot doesn't work for me. Nothing happens in the input field of the test. When I manually type "a" and then enter, the test passes. I have german keyboard layout. When I switch to English/US, nothing changes though. Any other ideas why that would happen?

[mrserb]

Maybe you do not provide the permission to java? Settings-> security&privacy-> select the "Accessibility" -> select all apps if not selected. I think if you run the test via jtreg then "Terminal" should be selected in "Accessibility" block.
The macOS asks the permission on the first access, you can try to reset all decisions by this command:
tccutil reset All

[RealCLanger]

Maybe you do not provide the permission to java? Settings-> security&privacy-> select the "Accessibility" -> select all apps if not selected. I think if you run the test via jtreg then "Terminal" should be selected in "Accessibility" block. The macOS asks the permission on the first access, you can try to reset all decisions by this command: tccutil reset All

Yep, that's it. I was googling and also found reports of similar issues. After I added Accessibility permissions to the terminal app, it seems to work. It's a bit unfortunate, that the robot doesn't fail to initialize when the permission isn't present.

Thanks a lot for your help!

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 167c9f0.
Since your change was applied there have been 21 commits pushed to the master branch:

• 968c21e: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
• 90d1bcb: 8261071: AArch64: Refactor interpreter native wrappers
• 15931e5: 8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
• 15384ad: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
• 4557503: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
• 844c504: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
• 4940e2e: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
• 0a71d8e: 8221305: java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris
• d336b24: 8253015: Aarch64: Move linux code out from generic CPU feature detection
• 2a028c4: 8180568: Refactor javax/crypto shell tests to plain java tests
• ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/158c0a8c16974e1eb2021fd36f9032fb0f150a34...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 167c9f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.