Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics #78

Closed
wants to merge 2 commits into from

Conversation

jnimeh
Copy link
Member

@jnimeh jnimeh commented Dec 28, 2022

This adds documentation to the java(1) man page for new ChaCha20 and Poly1305 intrinsics, highlighting the diagnostic flags that were delivered in those feature enhancements. This is similar to what has already been done for AES and GHASH diagnostic flags.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.org/jdk20 pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/78.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2022

👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@jnimeh To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jnimeh
Copy link
Member Author

jnimeh commented Dec 28, 2022

/label security

@jnimeh
Copy link
Member Author

jnimeh commented Dec 28, 2022

/label javadoc

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@jnimeh
The security label was successfully added.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@jnimeh
The javadoc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 28, 2022

Webrevs

@jnimeh
Copy link
Member Author

jnimeh commented Dec 28, 2022

/label hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@jnimeh
The hotspot label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@jnimeh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 188911c: 8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file
  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2022
@jnimeh
Copy link
Member Author

jnimeh commented Dec 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit 37f8b05.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 188911c: 8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file
  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@jnimeh Pushed as commit 37f8b05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jnimeh jnimeh deleted the JDK-8298592 branch January 6, 2023 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants