Skip to content

8297166: [TestBug] Fix some ignored unit test from TableViewTest #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8297166: [TestBug] Fix some ignored unit test from TableViewTest #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,8 @@ public void cleanup() {
assertEquals("Pineapple", sm.getSelectedItem());
}

@Ignore("Not fixed yet")
@Test public void ensureSelectionShiftsDownWhenOneNewItemIsAdded() {
@Test
public void ensureSelectionShiftsDownWhenOneNewItemIsAdded() {
table.getItems().addAll("Apple", "Orange", "Banana");
sm.select(1);
assertEquals(1, sm.getSelectedIndex());
Expand All @@ -315,8 +315,8 @@ public void cleanup() {
assertEquals("Orange", sm.getSelectedItem());
}

@Ignore("Not fixed yet")
@Test public void ensureSelectionShiftsDownWhenMultipleNewItemAreAdded() {
@Test
public void ensureSelectionShiftsDownWhenMultipleNewItemAreAdded() {
table.getItems().addAll("Apple", "Orange", "Banana");
sm.select(1);
assertEquals(1, sm.getSelectedIndex());
Expand All @@ -327,8 +327,8 @@ public void cleanup() {
assertEquals(4, sm.getSelectedIndex());
}

@Ignore("Not fixed yet")
@Test public void ensureSelectionShiftsDownWhenOneItemIsRemoved() {
@Test
public void ensureSelectionShiftsDownWhenOneItemIsRemoved() {
table.getItems().addAll("Apple", "Orange", "Banana");
sm.select(1);
assertEquals(1, sm.getSelectedIndex());
Expand All @@ -339,8 +339,8 @@ public void cleanup() {
assertEquals("Orange", sm.getSelectedItem());
}

@Ignore("Not fixed yet")
@Test public void ensureSelectionShiftsDownWheMultipleItemsAreRemoved() {
@Test
public void ensureSelectionShiftsDownWheMultipleItemsAreRemoved() {
table.getItems().addAll("Apple", "Orange", "Banana");
sm.select(2);
assertEquals(2, sm.getSelectedIndex());
Expand Down Expand Up @@ -437,8 +437,8 @@ class Person {
assertEquals(0, table.getVisibleLeafColumns().size());
}

@Test public void testSortOrderCleanup() {
// ObservableList<ObservablePerson> persons = ObservablePerson.createFXPersonList();
@Test
public void testSortOrderCleanup() {
TableView table = new TableView();
TableColumn<String,String> first = new TableColumn<String,String>("first");
first.setCellValueFactory(new PropertyValueFactory("firstName"));
Expand Down Expand Up @@ -728,8 +728,8 @@ private TableColumn<String, String> initSortTestStructure() {
VirtualFlowTestUtils.assertListContainsItemsInOrder(c.getColumns(), col);
}

@Ignore
@Test public void testComparatorChangesInSyncWithSortOrder_2() {
@Test
public void testComparatorChangesInSyncWithSortOrder_2() {
// same as test above
TableColumn<String, String> col = initSortTestStructure();
assertNull(table.getComparator());
Expand Down Expand Up @@ -865,8 +865,12 @@ private TableColumn<String, String> initSortTestStructure() {
assertEquals(-1, tv.getSelectionModel().getSelectedIndex());
}

@Ignore("Started failing recently, but manual tests seem to indicate the functionality is intact")
@Test public void test_rt17522_focusShouldMoveWhenItemAddedAtFocusIndex() {
/**
* JDK-8119787
* @ Ignore("Started failing recently, but manual tests seem to indicate the functionality is intact")
*/
@Test
public void test_rt17522_focusShouldMoveWhenItemAddedAtFocusIndex() {
final TableView lv = new TableView();
StageLoader sl = new StageLoader(lv);
FocusModel fm = lv.getFocusModel();
Expand Down Expand Up @@ -2047,8 +2051,12 @@ public TableCell<Person, String> call(TableColumn<Person, String> p) {
sl.dispose();
}

// @Ignore("Test started intermittently failing, most probably due to RT-36855 changeset")
@Test public void test_rt_34493() {
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment. If needed, we can get this information from looking at file revision history.

* JDK-8093986
* @ Ignore("Test started intermittently failing, most probably due to RT-36855/JDK-8096512 changeset")
*/
@Test
public void noAutoresizeOnColumnRemoval() {
TableView<Person> table = new TableView<>();
table.setItems(FXCollections.observableArrayList(
new Person("John", "Smith", "jacob.smith@example.com")
Expand Down