New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make lyric-syllable-magnetic-snap work with recent versions #128

Open

akobel wants to merge 1 commit into openlilylib:master from akobel:master

Contributor

akobel commented Jul 27, 2015

No description provided.

Contributor

uliska commented Jul 28, 2015

Just looking at the commit through the web interface, and I have a question:
Will the changed code work with only new LilyPonds (if so, starting with which version exactly?) or with older and newer versions?

If this is a breaking change it might be a good idea to wrap it with the lilypond-version-predicates. And it should be documented.

Contributor Author

akobel commented Jul 29, 2015

Indeed, good point. At least it does not work anymore with v2.18.2.
I need to check which change was responsible for the different behaviour. As a reminder to myself: an educated guess after git grep grob-propert is something around 2.19.10 or 2.19.11, but I have yet to confirm this.

BTW, this fix only makes Lilypond to accept the input; it does not (aim to) make the entire approach work. Just saying, because it doesn't work, or at least not reliably.

Contributor

uliska commented Oct 23, 2015

BTW, the Success messages of the Continuous Integration server don't say anything because they really only test the units in the new structure that do have "unit tests".

Contributor

uliska commented Nov 8, 2016

@akobel could you have a look into this if it is still relevant, needs more work, can be merged or should be dropped?

akobel closed this

akobel force-pushed the master branch from e8b0614 to b2a77df Compare

December 25, 2016 22:49

Contributor Author

akobel commented Dec 26, 2016

Closed "by accident", while rebasing to the current master. This is still relevant.

I use the lilypond-version-predicates now. Still no docs, though, just a mini-fix in the source.

akobel reopened this


          make lyric-syllable-magnetic-snap work with Lily >= 2.19.11

bbba147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet