chore(deps): update hack/common digest to 80bfca5 (#51)

* chore(deps): update hack/common digest to 80bfca5

* chore(fix): golang-lint v2 changes

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Günther Wannenmacher <guenther.wannenmacher@sap.com>

Author: renovate[bot]

.golangci.yaml

@@ -1,8 +1,49 @@
+version: "2"
 run:
-  concurrency: 4
-  timeout: 10m
-
-issues:
-  exclude-files:
-  - "zz_generated.*\\.go$"
-  - "tmp/.*"
+  allow-parallel-runners: true
+linters:
+  default: none
+  enable:
+    - copyloopvar
+#    - dupl
+    - errcheck
+#    - ginkgolinter
+#    - goconst
+    - gocyclo
+    - govet
+    - ineffassign
+    - misspell
+    - nakedret
+#    - prealloc
+#    - revive
+    - staticcheck
+    - unconvert
+    - unparam
+    - unused
+  settings:
+    revive:
+      rules:
+        - name: comment-spacings
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - zz_generated.*\.go$
+      - tmp/.*
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

hack/common

@@ -237,15 +237,15 @@ func copyRestConfig(from, to *rest.Config) {
 	to.AuthProvider = from.AuthProvider
 	to.AuthConfigPersister = from.AuthConfigPersister
 	to.ExecProvider = from.ExecProvider
-	to.TLSClientConfig.Insecure = from.TLSClientConfig.Insecure
-	to.TLSClientConfig.ServerName = from.TLSClientConfig.ServerName
-	to.TLSClientConfig.CertFile = from.TLSClientConfig.CertFile
-	to.TLSClientConfig.KeyFile = from.TLSClientConfig.KeyFile
-	to.TLSClientConfig.CAFile = from.TLSClientConfig.CAFile
-	to.TLSClientConfig.CertData = from.TLSClientConfig.CertData
-	to.TLSClientConfig.KeyData = from.TLSClientConfig.KeyData
-	to.TLSClientConfig.CAData = from.TLSClientConfig.CAData
-	to.TLSClientConfig.NextProtos = from.TLSClientConfig.NextProtos
+	to.Insecure = from.Insecure
+	to.ServerName = from.ServerName
+	to.CertFile = from.CertFile
+	to.KeyFile = from.KeyFile
+	to.CAFile = from.CAFile
+	to.CertData = from.CertData
+	to.KeyData = from.KeyData
+	to.CAData = from.CAData
+	to.NextProtos = from.NextProtos
 	to.UserAgent = from.UserAgent
 	to.DisableCompression = from.DisableCompression
 	to.Transport = from.Transport

pkg/clientconfig/clientconfig.go

@@ -40,7 +40,7 @@ func NewLinkedList[T any](elements ...T) *LinkedList[T] {
 	res.dummy.next = res.dummy
 	res.dummy.prev = res.dummy
 
-	res.abstractCollection.funcIterator = res.Iterator
+	res.funcIterator = res.Iterator
 	res.funcAdd = res.Add
 	res.funcClear = res.Clear
 	res.funcRemove = res.Remove

pkg/collections/list-linked.go

@@ -20,12 +20,12 @@ var _ = Describe("Annotation/Label Library", func() {
 		Context("IsMetadataEntryAlreadyExistsError", func() {
 
 			It("should return true if the error is of type IsMetadataEntryAlreadyExistsError", func() {
-				var err error = ctrlutils.NewMetadataEntryAlreadyExistsError(ctrlutils.ANNOTATION, "test-annotation", "desired-value", "actual-value")
+				err := ctrlutils.NewMetadataEntryAlreadyExistsError(ctrlutils.ANNOTATION, "test-annotation", "desired-value", "actual-value")
 				Expect(ctrlutils.IsMetadataEntryAlreadyExistsError(err)).To(BeTrue())
 			})
 
 			It("should return false if the error is not of type IsMetadataEntryAlreadyExistsError", func() {
-				var err error = fmt.Errorf("test-error")
+				err := fmt.Errorf("test-error")
 				Expect(ctrlutils.IsMetadataEntryAlreadyExistsError(err)).To(BeFalse())
 			})
 
@@ -213,12 +213,12 @@ var _ = Describe("Annotation/Label Library", func() {
 		Context("IsMetadataEntryAlreadyExistsError", func() {
 
 			It("should return true if the error is of type IsMetadataEntryAlreadyExistsError", func() {
-				var err error = ctrlutils.NewMetadataEntryAlreadyExistsError(ctrlutils.LABEL, "test-label", "desired-value", "actual-value")
+				err := ctrlutils.NewMetadataEntryAlreadyExistsError(ctrlutils.LABEL, "test-label", "desired-value", "actual-value")
 				Expect(ctrlutils.IsMetadataEntryAlreadyExistsError(err)).To(BeTrue())
 			})
 
 			It("should return false if the error is not of type IsMetadataEntryAlreadyExistsError", func() {
-				var err error = fmt.Errorf("test-error")
+				err := fmt.Errorf("test-error")
 				Expect(ctrlutils.IsMetadataEntryAlreadyExistsError(err)).To(BeFalse())
 			})
 

pkg/controller/annotation_label_test.go

@@ -7,7 +7,7 @@ import (
 	"reflect"
 	"time"
 
-	. "github.com/onsi/gomega"
+	"github.com/onsi/gomega"
 	"k8s.io/apimachinery/pkg/runtime"
 	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -61,7 +61,7 @@ func (e *ComplexEnvironment) ShouldReconcile(reconciler string, req reconcile.Re
 
 func (e *ComplexEnvironment) shouldReconcile(reconciler string, req reconcile.Request, optionalDescription ...interface{}) reconcile.Result {
 	res, err := e.Reconcilers[reconciler].Reconcile(e.Ctx, req)
-	ExpectWithOffset(2, err).ToNot(HaveOccurred(), optionalDescription...)
+	gomega.ExpectWithOffset(2, err).ToNot(gomega.HaveOccurred(), optionalDescription...)
 	return res
 }
 
@@ -73,10 +73,10 @@ func (e *ComplexEnvironment) ShouldEventuallyReconcile(reconciler string, req re
 func (e *ComplexEnvironment) shouldEventuallyReconcile(reconciler string, req reconcile.Request, timeout, poll time.Duration, optionalDescription ...interface{}) reconcile.Result {
 	var err error
 	var res reconcile.Result
-	EventuallyWithOffset(1, func() error {
+	gomega.EventuallyWithOffset(1, func() error {
 		res, err = e.Reconcilers[reconciler].Reconcile(e.Ctx, req)
 		return err
-	}, timeout, poll).Should(Succeed(), optionalDescription...)
+	}, timeout, poll).Should(gomega.Succeed(), optionalDescription...)
 	return res
 }
 
@@ -87,7 +87,7 @@ func (e *ComplexEnvironment) ShouldNotReconcile(reconciler string, req reconcile
 
 func (e *ComplexEnvironment) shouldNotReconcile(reconciler string, req reconcile.Request, optionalDescription ...interface{}) reconcile.Result {
 	res, err := e.Reconcilers[reconciler].Reconcile(e.Ctx, req)
-	ExpectWithOffset(2, err).To(HaveOccurred(), optionalDescription...)
+	gomega.ExpectWithOffset(2, err).To(gomega.HaveOccurred(), optionalDescription...)
 	return res
 }
 
@@ -99,10 +99,10 @@ func (e *ComplexEnvironment) ShouldEventuallyNotReconcile(reconciler string, req
 func (e *ComplexEnvironment) shouldEventuallyNotReconcile(reconciler string, req reconcile.Request, timeout, poll time.Duration, optionalDescription ...interface{}) reconcile.Result {
 	var err error
 	var res reconcile.Result
-	EventuallyWithOffset(1, func() error {
+	gomega.EventuallyWithOffset(1, func() error {
 		res, err = e.Reconcilers[reconciler].Reconcile(e.Ctx, req)
 		return err
-	}, timeout, poll).ShouldNot(Succeed(), optionalDescription...)
+	}, timeout, poll).ShouldNot(gomega.Succeed(), optionalDescription...)
 	return res
 }